Page MenuHomePhabricator

Added OP_BSWAP opcode without tests or behavior.
AbandonedPublic

Authored by tobias_ruck on Jan 8 2020, 15:25.

Details

Reviewers
deadalnix
markblundeberg
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

OP_BSWAP has been added to enums, assigned the number 0xbc. T707

Test Plan

This doesn't change the behavior in any way (except for how OP_BSWAP will be displayed), so adding tests seems unwarranted. Also, there already is a bswap_tests.cpp. I suggest renaming that file to byteswap_tests.cpp to allow OP_BSWAP to have a test file that's easier recognizable.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
OP_ENDIAN_REVERSE
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8824
Build 15623: Default Diff Build & Tests
Build 15622: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jan 8 2020, 15:25

Fixed OP_BSWAP opcode number in script.py

Added OP_BSWAP opcode without tests or behavior.

deadalnix requested changes to this revision.Jan 9 2020, 13:10

Back on your queue untill the situation with D4871 is sorted out.

This revision now requires changes to proceed.Jan 9 2020, 13:10

Collapsed reversed_data generation code.

Accidentially updated wrong diff....