Page MenuHomePhabricator

Added OP_BSWAP opcode without tests or behavior.
AbandonedPublic

Authored by tobias_ruck on Wed, Jan 8, 15:25.

Details

Reviewers
deadalnix
markblundeberg
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

OP_BSWAP has been added to enums, assigned the number 0xbc. T707

Test Plan

This doesn't change the behavior in any way (except for how OP_BSWAP will be displayed), so adding tests seems unwarranted. Also, there already is a bswap_tests.cpp. I suggest renaming that file to byteswap_tests.cpp to allow OP_BSWAP to have a test file that's easier recognizable.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
OP_ENDIAN_REVERSE
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8824
Build 15623: Bitcoin ABC Buildbot
Build 15622: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Wed, Jan 8, 15:25
Owners added a reviewer: Restricted Owners Package.Wed, Jan 8, 15:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jan 8, 15:25
tobias_ruck updated this revision to Diff 15238.Wed, Jan 8, 17:02

Fixed OP_BSWAP opcode number in script.py

tobias_ruck updated this revision to Diff 15239.Wed, Jan 8, 17:09

Added OP_BSWAP opcode without tests or behavior.

tobias_ruck edited the summary of this revision. (Show Details)Wed, Jan 8, 19:04
deadalnix requested changes to this revision.Thu, Jan 9, 13:10

Back on your queue untill the situation with D4871 is sorted out.

This revision now requires changes to proceed.Thu, Jan 9, 13:10
tobias_ruck abandoned this revision.Thu, Jan 9, 16:16

will be merged with D4871

tobias_ruck updated this revision to Diff 15287.Fri, Jan 10, 00:57

Collapsed reversed_data generation code.

tobias_ruck abandoned this revision.Fri, Jan 10, 01:00

Accidentially updated wrong diff....