Page MenuHomePhabricator
Differential D4859

Added OP_BSWAP opcode without tests or behavior.
AbandonedPublic
Actions

Authored by tobias_ruck on Jan 8 2020, 15:25.

Details

Reviewers
deadalnix
markblundeberg
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

OP_BSWAP has been added to enums, assigned the number 0xbc. T707

Test Plan

This doesn't change the behavior in any way (except for how OP_BSWAP will be displayed), so adding tests seems unwarranted. Also, there already is a bswap_tests.cpp. I suggest renaming that file to byteswap_tests.cpp to allow OP_BSWAP to have a test file that's easier recognizable.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
OP_BSWAP
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8787
Build 15555: Default Diff Build & Tests
Build 15554: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Jan 8 2020, 15:25
Owners added a reviewer: Restricted Owners Package.Jan 8 2020, 15:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 8 2020, 15:25
teamcity added a comment.Jan 8 2020, 15:26

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 8 2020, 15:44

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8787: Diff 15228.Jan 8 2020, 15:44
Fabien mentioned this in D4864: Fixed OP_BSWAP opcode number in script.py..Jan 8 2020, 16:07
tobias_ruck updated this revision to Diff 15238.Jan 8 2020, 17:02

Fixed OP_BSWAP opcode number in script.py

teamcity added a comment.Jan 8 2020, 17:02

Build Bitcoin-ABC / Diffs / Diff Testing started.

tobias_ruck updated this revision to Diff 15239.Jan 8 2020, 17:09

Added OP_BSWAP opcode without tests or behavior.

teamcity added a comment.Jan 8 2020, 17:09

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 8 2020, 17:09

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8797: Diff 15238.Jan 8 2020, 17:09
teamcity added a comment.Jan 8 2020, 17:17

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8798: Diff 15239.Jan 8 2020, 17:17
tobias_ruck edited the summary of this revision. (Show Details)Jan 8 2020, 19:04
markblundeberg mentioned this in D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.Jan 9 2020, 00:33
tobias_ruck added a child revision: D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.Jan 9 2020, 09:27
deadalnix requested changes to this revision.Jan 9 2020, 13:10

Back on your queue untill the situation with D4871 is sorted out.

This revision now requires changes to proceed.Jan 9 2020, 13:10
tobias_ruck abandoned this revision.Jan 9 2020, 16:16

will be merged with D4871

tobias_ruck updated this revision to Diff 15287.Jan 10 2020, 00:57

Collapsed reversed_data generation code.

teamcity added a comment.Jan 10 2020, 00:58

Build Bitcoin-ABC / Diffs / Diff Testing started.

tobias_ruck abandoned this revision.Jan 10 2020, 01:00

Accidentially updated wrong diff....

teamcity added a comment.Jan 10 2020, 01:03

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8824: Diff 15287.Jan 10 2020, 01:03
markblundeberg removed a child revision: D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.Jan 27 2020, 03:21

Revision Contents
Changeset List

PathSize
src/
script/
3 lines
2 lines
test/
functional/
test_framework/
3 lines

Diff 15228

View Options

src/script/script.h

Loading...
View Options

src/script/script.cpp

Loading...
View Options

test/functional/test_framework/script.py

Loading...