Revert "Call FinalizeBlockAndInvalidate without cs_main held"
ClosedPublic
Actions

Authored by deadalnix on Jan 15 2020, 13:18.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING6060acc50a38: Revert "Call FinalizeBlockAndInvalidate without cs_main held"
rABC6060acc50a38: Revert "Call FinalizeBlockAndInvalidate without cs_main held"

Summary

This reverts commit baef60890b540715de692b41cb45a932f5866d45.

This patch's locking is broken.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

backout4942

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8955
Build 15883: Default Diff Build & Tests
Build 15882: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 15 2020, 13:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 15 2020, 13:18

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien accepted this revision.Jan 15 2020, 13:21

This revision is now accepted and ready to land.Jan 15 2020, 13:21

This revision was landed with ongoing or failed builds.Jan 15 2020, 13:22

Closed by commit rABC6060acc50a38: Revert "Call FinalizeBlockAndInvalidate without cs_main held" (authored by deadalnix). · Explain Why

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC6060acc50a38: Revert "Call FinalizeBlockAndInvalidate without cs_main held".

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8955: Diff 15478.Jan 15 2020, 13:24

fpelliccioni mentioned this in D4945: Revert D4942 locking 'time'.Jan 20 2020, 17:20

deadalnix added a commit: rSTAGING6060acc50a38: Revert "Call FinalizeBlockAndInvalidate without cs_main held".Apr 7 2020, 22:26

Revision Contents
Changeset List

Path

Size

src/

rpc/

blockchain.cpp

6 lines

validation.h

3 lines

validation.cpp

31 lines

Diff 15478

View Options

src/rpc/blockchain.cpp

View Options

src/validation.h

View Options

Revert "Call FinalizeBlockAndInvalidate without cs_main held"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 15478

src/rpc/blockchain.cpp

src/validation.h

src/validation.cpp

Revert "Call FinalizeBlockAndInvalidate without cs_main held"
ClosedPublic
Actions

Revision Contents
Changeset List