[CMAKE] Add compiler flags to some build configuration only
ClosedPublic
Actions

Authored by Fabien on Jan 15 2020, 17:04.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGbe3622b4f150: [CMAKE] Add compiler flags to some build configuration only
rABCbe3622b4f150: [CMAKE] Add compiler flags to some build configuration only

Summary

This adds new facilities to add flags or definitions that only apply to
some build configuration. This is especially useful to pass debug only
flags.

Test Plan

cmake -GNinja .. -DCMAKE_BUILD_TYPE=Debug
ninja -v check

Ensure the flags and definitions are correctly passed on the compilation
lines.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 15 2020, 17:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 15 2020, 17:04

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8960: Diff 15487.Jan 15 2020, 17:12

deadalnix accepted this revision.Jan 15 2020, 22:23

This revision is now accepted and ready to land.Jan 15 2020, 22:23

Closed by commit rABCbe3622b4f150: [CMAKE] Add compiler flags to some build configuration only (authored by Fabien). · Explain WhyJan 16 2020, 08:52

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCbe3622b4f150: [CMAKE] Add compiler flags to some build configuration only.

Fabien added a commit: rSTAGINGbe3622b4f150: [CMAKE] Add compiler flags to some build configuration only.Apr 7 2020, 22:28

Revision Contents
Changeset List

Path

Size

cmake/

modules/

AddCompilerFlags.cmake

15 lines

src/

CMakeLists.txt

6 lines

Diff 15515

View Options

cmake/modules/AddCompilerFlags.cmake