Page MenuHomePhabricator
Differential D4964

Merge #15507: test: Bump timeout on tests
ClosedPublic
Actions

Authored by jasonbcox on Jan 16 2020, 22:46.

Details

Reviewers
deadalnix
nakihito
Group Reviewers
Restricted Project
Commits
rSTAGINGff3a2b5084c7: Merge #15507: test: Bump timeout on tests
rABCff3a2b5084c7: Merge #15507: test: Bump timeout on tests
Summary

fa852f0e8d test: Bump timeout on tests that timeout on windows (MarcoFalke)

Pull request description:

Those tests build a ton of blocks and time out for me on Windows with:

```
test_framework.authproxy.JSONRPCException: 'generatetoaddress' RPC took longer than 60.000000 seconds. Consider using larger timeout for calls that take longer to return. (-344)

Tree-SHA512: a8fffeaddd02c051fbcc04bfac69f6ed826b8f16616e3b2e210a469d07c3e5706baab8121f1cd7ed265481de3a6197cf371513e2afbe506cf13b1dabfe3a0005

Backport of Core PR15507
https://github.com/bitcoin/bitcoin/pull/15507/files

We're seeing these timeouts occasionally on CI: https://build.bitcoinabc.org/viewLog.html?buildId=26186&buildTypeId=BitcoinABC_Master_BitcoinAbcMasterUbsan&tab=buildLog&state=&expand=all&_focus=857#_state=

Test Plan

test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15507
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8986
Build 15934: Default Diff Build & Tests
Build 15933: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jan 16 2020, 22:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 16 2020, 22:46
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jan 16 2020, 22:46

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox added inline comments.Jan 16 2020, 22:47
test/functional/feature_assumevalid.py
194

This doesn't match the original PR because we skipped this backport: https://github.com/bitcoin/bitcoin/pull/15022/files

teamcity added a comment.Jan 16 2020, 22:51

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8986: Diff 15535.Jan 16 2020, 22:51
nakihito accepted this revision.Jan 16 2020, 22:52
This revision is now accepted and ready to land.Jan 16 2020, 22:52
Closed by commit rABCff3a2b5084c7: Merge #15507: test: Bump timeout on tests (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyJan 16 2020, 23:06
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCff3a2b5084c7: Merge #15507: test: Bump timeout on tests.
jasonbcox added a commit: rSTAGINGff3a2b5084c7: Merge #15507: test: Bump timeout on tests.Apr 7 2020, 22:29

Revision Contents
Changeset List

PathSize
test/
functional/
2 lines
1 line
1 line

Diff 15535

View Options

test/functional/feature_assumevalid.py

Loading...
View Options

test/functional/feature_cltv.py

Loading...
View Options

test/functional/feature_dersig.py

Loading...