Page MenuHomePhabricator
Differential D5014

simplify ATMP standard flag computation [1/2] - remove CHECKDATASIG_SIGOPS
ClosedPublic
Actions

Authored by markblundeberg on Jan 18 2020, 11:02.

Details

Reviewers
Mengerian
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING2d1c6597e5ee: simplify ATMP standard flag computation [1/2] - remove CHECKDATASIG_SIGOPS
rABC2d1c6597e5ee: simplify ATMP standard flag computation [1/2] - remove CHECKDATASIG_SIGOPS
Summary

This flag is already part of STANDARD_SCRIPT_VERIFY_FLAGS, and anyway
it doesn't matter here since CheckInputs does not care about sigops.

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.Jan 18 2020, 11:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 18 2020, 11:02
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jan 18 2020, 11:02

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg added a child revision: D5015: simplify ATMP standard flag computation [2/2] - move computation to another function.Jan 18 2020, 11:04
teamcity added a comment.Jan 18 2020, 11:17

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9049: Diff 15647.Jan 18 2020, 11:17
deadalnix accepted this revision.Jan 18 2020, 23:30
This revision is now accepted and ready to land.Jan 18 2020, 23:30
Closed by commit rABC2d1c6597e5ee: simplify ATMP standard flag computation [1/2] - remove CHECKDATASIG_SIGOPS (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyJan 19 2020, 02:09
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC2d1c6597e5ee: simplify ATMP standard flag computation [1/2] - remove CHECKDATASIG_SIGOPS.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING2d1c6597e5ee: simplify ATMP standard flag computation [1/2] - remove CHECKDATASIG_SIGOPS.Apr 7 2020, 22:34

Revision Contents
Changeset List

PathSize
src/
11 lines

Diff 15660

View Options

src/validation.cpp

Loading...