Page MenuHomePhabricator

[CMAKE] Fix static linkage when building for Windows
ClosedPublic

Authored by Fabien on Jan 19 2020, 10:45.

Details

Summary

The -static flag is obviously a linker flag and not a compilation
flag. It used to work due to the CMAKE_<C|CXX>_FLAGS being passed at
link time, hiding the initial issue. The bug is revealed by D4947: while
the cross build still succeed, it is no longer static.

Test Plan

Run the Gitian build for Windows. Run the bitcoin-qt.exe executable
and check it runs and does not complain about missing DLLs.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_fix_windows_static_linking
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9067
Build 16096: Default Diff Build & Tests
Build 16095: arc lint + arc unit

Event Timeline

Rebase on top of D5024 in order for the gitian build to succeed.

This revision is now accepted and ready to land.Jan 19 2020, 13:58