Page MenuHomePhabricator
Differential D5023

[CMAKE] Fix static linkage when building for Windows
ClosedPublic
Actions

Authored by Fabien on Jan 19 2020, 10:45.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGb53c0fcaff0e: [CMAKE] Fix static linkage when building for Windows
rABCb53c0fcaff0e: [CMAKE] Fix static linkage when building for Windows
Summary

The -static flag is obviously a linker flag and not a compilation
flag. It used to work due to the CMAKE_<C|CXX>_FLAGS being passed at
link time, hiding the initial issue. The bug is revealed by D4947: while
the cross build still succeed, it is no longer static.

Test Plan

Run the Gitian build for Windows. Run the bitcoin-qt.exe executable
and check it runs and does not complain about missing DLLs.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 19 2020, 10:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 19 2020, 10:45
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jan 19 2020, 10:45

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 19 2020, 10:50

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9064: Diff 15666.Jan 19 2020, 10:50
Fabien updated this revision to Diff 15669.Jan 19 2020, 12:30

Rebase on top of D5024 in order for the gitian build to succeed.

teamcity added a comment.Jan 19 2020, 12:31

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 19 2020, 12:32

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Jan 19 2020, 12:35

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9067: Diff 15669.Jan 19 2020, 12:35
teamcity added a comment.Jan 19 2020, 12:40

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

deadalnix accepted this revision.Jan 19 2020, 13:58
This revision is now accepted and ready to land.Jan 19 2020, 13:58
Closed by commit rABCb53c0fcaff0e: [CMAKE] Fix static linkage when building for Windows (authored by Fabien). · Explain WhyJan 19 2020, 14:05
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCb53c0fcaff0e: [CMAKE] Fix static linkage when building for Windows.
Fabien added a commit: rSTAGINGb53c0fcaff0e: [CMAKE] Fix static linkage when building for Windows.Apr 7 2020, 22:34

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 15671

View Options

src/CMakeLists.txt

Loading...