Page MenuHomePhabricator
Differential D5034

[CMAKE] Fix the native build when the target is in the current build dir
ClosedPublic
Actions

Authored by Fabien on Jan 21 2020, 09:36.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING36c653c2d57f: [CMAKE] Fix the native build when the target is in the current build dir
rABC36c653c2d57f: [CMAKE] Fix the native build when the target is in the current build dir
Summary

When the CMAKE_CURRENT_BINARY_DIR is the same than CMAKE_BINARY_DIR,
the computed relative path is empty and the target name starts with a
/, inserting a double slash // in the path at the same time.

This diff fixes the issue by not prepending the relative path to the
target name if it is empty.

Test Plan

Build bitcoin-abc and secp256k1 standalone.
See Travis result from my secp256k1 repo fork:
https://travis-ci.org/Fabcien/secp256k1/builds/639912900
Depends on D5033 to make Travis happy.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 21 2020, 09:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2020, 09:36
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jan 21 2020, 09:36

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 21 2020, 09:41

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9088: Diff 15704.Jan 21 2020, 09:41
Fabien mentioned this in D5036: [CMAKE] Don't sort empty list.Jan 21 2020, 11:30
Fabien edited the test plan for this revision. (Show Details)Jan 21 2020, 12:42
deadalnix accepted this revision.Jan 21 2020, 13:59
This revision is now accepted and ready to land.Jan 21 2020, 13:59
Closed by commit rABC36c653c2d57f: [CMAKE] Fix the native build when the target is in the current build dir (authored by Fabien). · Explain WhyJan 21 2020, 14:29
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC36c653c2d57f: [CMAKE] Fix the native build when the target is in the current build dir.
Fabien added a commit: rSTAGING36c653c2d57f: [CMAKE] Fix the native build when the target is in the current build dir.Apr 7 2020, 22:36

Revision Contents
Changeset List

PathSize
cmake/
modules/
5 lines

Diff 15712

View Options

cmake/modules/NativeExecutable.cmake

Loading...