Page MenuHomePhabricator

[CMAKE] Bump minimum version to 3.13
ClosedPublic

Authored by Fabien on Jan 21 2020, 10:34.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC1299f1cf2cfe: [CMAKE] Bump minimum version to 3.13
Summary

This version brings the add_link_options function that will allow to
attach linker flags to targets instead of overriding the
CMAKE_EXE_LINKER_FLAGS. It also fixes a bug with empty lists (see
summary in D5033 for details).

There is no major distribution packaging cmake 3.12 and not 3.13 so
there is no impact for developers and package maintainers (Fedora 29 is
an exception but has an update package to 3.14, see
https://pkgs.org/download/cmake).

This time I updated the required version for all the libs as well. Not
doing so makes the build brittle as these libs are using our top level
cmake modules. The version requirement for the src/CMakeLists.txt is
removed because it is a duplicate of the top-level CMakeLists.txt
file.

Depends on D5033.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Jan 21 2020, 10:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2020, 10:34
deadalnix accepted this revision.Jan 21 2020, 13:59
This revision is now accepted and ready to land.Jan 21 2020, 13:59
This revision was automatically updated to reflect the committed changes.