Page MenuHomePhabricator
Differential D5037

[CMAKE] Attach the linker flags to target properties
ClosedPublic
Actions

Authored by Fabien on Jan 21 2020, 13:34.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGb2c19452d7f6: [CMAKE] Attach the linker flags to target properties
rABCb2c19452d7f6: [CMAKE] Attach the linker flags to target properties
Summary

This is achieved by using the add_link_options function instead of
appending the flags to the global CMAKE_EXE_LINKER_FLAGS variable.

Depends on D5035.

Test Plan
ninja check

Run the Gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 21 2020, 13:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2020, 13:34
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jan 21 2020, 13:34

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 21 2020, 13:38

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9092: Diff 15709.Jan 21 2020, 13:39
deadalnix accepted this revision.Jan 21 2020, 14:00
This revision is now accepted and ready to land.Jan 21 2020, 14:00
teamcity added a comment.Jan 21 2020, 14:58

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Jan 21 2020, 14:59

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Jan 21 2020, 15:03

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Jan 21 2020, 15:03

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Jan 21 2020, 15:11

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Jan 21 2020, 15:11

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

Closed by commit rABCb2c19452d7f6: [CMAKE] Attach the linker flags to target properties (authored by Fabien). · Explain WhyJan 21 2020, 15:14
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCb2c19452d7f6: [CMAKE] Attach the linker flags to target properties.
Fabien added a commit: rSTAGINGb2c19452d7f6: [CMAKE] Attach the linker flags to target properties.Apr 7 2020, 22:36

Revision Contents
Changeset List

PathSize
cmake/
modules/
11 lines

Diff 15718

View Options

cmake/modules/AddCompilerFlags.cmake

Loading...