Page MenuHomePhabricator

[CMAKE] Attach the linker flags to target properties
ClosedPublic

Authored by Fabien on Jan 21 2020, 13:34.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCb2c19452d7f6: [CMAKE] Attach the linker flags to target properties
Summary

This is achieved by using the add_link_options function instead of
appending the flags to the global CMAKE_EXE_LINKER_FLAGS variable.

Depends on D5035.

Test Plan
ninja check

Run the Gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_link_options_to_target
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 9092
Build 16146: Bitcoin ABC Buildbot
Build 16145: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 21 2020, 13:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2020, 13:34
deadalnix accepted this revision.Jan 21 2020, 14:00
This revision is now accepted and ready to land.Jan 21 2020, 14:00
This revision was automatically updated to reflect the committed changes.