Page MenuHomePhabricator
Differential D5044

Add last missing part from PR12954
ClosedPublic
Actions

Authored by nakihito on Jan 22 2020, 20:56.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGa5b58641cce4: Add last missing part from PR12954
rABCa5b58641cce4: Add last missing part from PR12954
Summary

Pull request description:

This is purely a refactor with no behavior changes.

This creates a new class `BCLog::Logger` to encapsulate all global logging configuration and state.

Tree-SHA512: b34811f54a53b7375d7b6f84925453c6f2419d21179379ee28b3843d0f4ff8e22020de84a5e783453ea927e9074e32de8ecd05a6fa50d7bb05502001aaed8e53

Partial backport of Core PR12954
https://github.com/bitcoin/bitcoin/pull/12954/files#diff-d278fc7d6997679f1f7416c5eda758fcR92
https://github.com/bitcoin/bitcoin/pull/12954/files#diff-d278fc7d6997679f1f7416c5eda758fcR147

Most of the changes were already made in various patches over time (see D4531 and D5010 for examples). This is only adding the last missing Enabled() function which will reducing our code ownership and make future backports easier.

Test Plan
make check
./bitcoind -printtoconsole=0 -debuglogfile=0

Perform some RPC calls and verify no log information is printed.

./bitcoind

Verify logging information is printed to console.

./bitcoind -printtoconsole=0

Verify logging information is printed to the default debug.log file.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12954
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9109
Build 16179: Default Diff Build & Tests
Build 16178: arc lint + arc unit

Event Timeline

nakihito created this revision.Jan 22 2020, 20:56
Owners added a reviewer: Restricted Owners Package.Jan 22 2020, 20:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 22 2020, 20:56
teamcity edited the summary of this revision. (Show Details)Jan 22 2020, 20:56

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Jan 22 2020, 20:57

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito edited the summary of this revision. (Show Details)Jan 22 2020, 21:00
teamcity added a comment.Jan 22 2020, 21:03

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9109: Diff 15746.Jan 22 2020, 21:03
jasonbcox accepted this revision.Jan 23 2020, 00:11
This revision is now accepted and ready to land.Jan 23 2020, 00:11
Closed by commit rABCa5b58641cce4: Add last missing part from PR12954 (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by nakihito). · Explain WhyJan 23 2020, 00:18
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCa5b58641cce4: Add last missing part from PR12954.
nakihito added a commit: rSTAGINGa5b58641cce4: Add last missing part from PR12954.Apr 7 2020, 22:37

Revision Contents
Changeset List

PathSize
src/
30 lines

Diff 15746

View Options

src/logging.h

Loading...