Page MenuHomePhabricator

[Tests] Suppress output in test_bitcoin for expected errors
ClosedPublic

Authored by Fabien on Jan 23 2020, 15:11.

Details

Summary
This adds two methods to noui, that allows temporarily suppressing (and
then resuming) the output from noui. For situations where errors are
expected, it's confusing for the test binary to output an error and then
conclude with No errors detected.

It also uses this supress/reconnect in the tests that currently produce
verbose errors when running test_bitcoin.

Backport of core PR16277.

Depends on D5050 (for the test plan) and D5052.

Test Plan
ninja test_bitcoin
./src/test/test_bitcoin --log_level=message

Check the -walletdir error messages (from D5004) are no longer printed
to console.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR16277
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9119
Build 16197: Default Diff Build & Tests
Build 16196: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Jan 25 2020, 02:34