Page MenuHomePhabricator
Differential D5058

Remove ENABLE_WALLET from libbitcoin_server.a
ClosedPublic
Actions

Authored by Fabien on Jan 24 2020, 08:12.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING86358f370208: Remove ENABLE_WALLET from libbitcoin_server.a
rABC86358f370208: Remove ENABLE_WALLET from libbitcoin_server.a
Summary

Backport of core PR14168.

Depends on D5054.

Test Plan
ninja all check
make check

cmake -GNinja .. -DBUILD_BITCOIN_WALLET=OFF
ninja all check

../configure --disable-wallet
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14168
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9124
Build 16207: Default Diff Build & Tests
Build 16206: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 24 2020, 08:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2020, 08:12
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity edited the summary of this revision. (Show Details)Jan 24 2020, 08:12

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Jan 24 2020, 08:12

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 24 2020, 08:17

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9124: Diff 15765.Jan 24 2020, 08:17
Fabien added a child revision: D5064: Add skeleton chain and client classes.Jan 24 2020, 20:42
deadalnix edited the summary of this revision. (Show Details)Jan 25 2020, 16:11
deadalnix accepted this revision.Jan 25 2020, 16:22
This revision is now accepted and ready to land.Jan 25 2020, 16:22
Closed by commit rABC86358f370208: Remove ENABLE_WALLET from libbitcoin_server.a (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJan 27 2020, 16:02
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC86358f370208: Remove ENABLE_WALLET from libbitcoin_server.a.
Fabien added a commit: rSTAGING86358f370208: Remove ENABLE_WALLET from libbitcoin_server.a.Apr 7 2020, 22:39

Revision Contents
Changeset List

PathSize
src/
2 lines
4 lines
38 lines
15 lines
3 lines
32 lines
wallet/
3 lines
4 lines

Diff 15765

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/dummywallet.cpp

Loading...
View Options

src/httprpc.cpp

Loading...
View Options

src/init.h

Loading...
View Options

src/init.cpp

Loading...
View Options

src/wallet/init.cpp

Loading...
View Options

src/walletinitinterface.h

Loading...