Ressurect BIP9 style activation mechanism
ClosedPublic
Actions

Authored by deadalnix on Feb 3 2020, 00:55.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING02de5cf341b3: Ressurect BIP9 style activation mechanism
rABC02de5cf341b3: Ressurect BIP9 style activation mechanism

Summary

This partially restore BIP9 style activation.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

bip9resurect

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9234
Build 16413: Default Diff Build & Tests
Build 16412: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 3 2020, 00:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 3 2020, 00:55

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9234: Diff 15949.Feb 3 2020, 01:01

deadalnix added a child revision: D5135: Restore BIP9 RPC support in getblockchaininfo.Feb 3 2020, 01:20

Reviewer note: This code is resurrected not from reverting past commits, but from Core's latest BIP9 code. This explains the differences from when it was removed to some things that are a little different (versionbitsinfo.h/cpp, way more comments, etc).

I also have some concerns on the rationale of this change, but we can discuss them offline.