Page MenuHomePhabricator
Differential D5135

Restore BIP9 RPC support in getblockchaininfo
ClosedPublic
Actions

Authored by deadalnix on Feb 3 2020, 01:20.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING42e749c2b184: Restore BIP9 RPC support in getblockchaininfo
rABC42e749c2b184: Restore BIP9 RPC support in getblockchaininfo
Summary

As per title.

Depends on D5134

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
bip9rpc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9250
Build 16443: Default Diff Build & Tests
Build 16442: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 3 2020, 01:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 3 2020, 01:20
teamcity added a comment.Feb 3 2020, 01:20

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 3 2020, 01:26

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9235: Diff 15950.Feb 3 2020, 01:26
deadalnix added a child revision: D5139: Ensure the thresold for BIP9 can be configured on a per activation basis..Feb 3 2020, 15:57
jasonbcox accepted this revision.Feb 3 2020, 23:17
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/rpc/blockchain.cpp
1282 ↗(On Diff #15950)

Can't wait for the new linter to land. Braces.

This revision is now accepted and ready to land.Feb 3 2020, 23:17
deadalnix updated this revision to Diff 15978.Feb 3 2020, 23:23

rebase

teamcity added a comment.Feb 3 2020, 23:23

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix updated this revision to Diff 15979.Feb 3 2020, 23:31

braces

teamcity added a comment.Feb 3 2020, 23:31

Build Bitcoin-ABC / Diffs / Diff Testing started.

This revision was landed with ongoing or failed builds.Feb 3 2020, 23:31
Closed by commit rABC42e749c2b184: Restore BIP9 RPC support in getblockchaininfo (authored by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC42e749c2b184: Restore BIP9 RPC support in getblockchaininfo.
teamcity added a comment.Feb 3 2020, 23:37

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9250: Diff 15979.Feb 3 2020, 23:37
teamcity added a comment.Feb 3 2020, 23:41

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9249: Diff 15978.Feb 3 2020, 23:41
deadalnix added a commit: rSTAGING42e749c2b184: Restore BIP9 RPC support in getblockchaininfo.Apr 7 2020, 22:47
PiRK mentioned this in D8075: [RPC] Fix casing in getblockchaininfo to be inline with the rest of the response.Oct 23 2020, 11:52
PiRK mentioned this in rABC761a61277750: [RPC] Fix casing in getblockchaininfo to be inline with the rest of the response.Oct 23 2020, 12:31

Revision Contents
Changeset List

PathSize
src/
rpc/
69 lines
21 lines
19 lines
test/
functional/
22 lines

Diff 15979

View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/functional/rpc_blockchain.py

Loading...