Page MenuHomePhabricator

Prevent wrapping in setexcessiveblock RPC
ClosedPublic

Authored by Fabien on Feb 3 2020, 10:27.

Details

Summary

If the blocksize parameter is a negative integer (not passed as a
string), it wraps and sets the incorrect value.
Incidently it removes the last use of boost::lexical_cast after D4080.

Test Plan
ninja all check
./test/functional/test_runner.py abc-rpc

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_excessiveblocksize_negative
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9237
Build 16419: Default Diff Build & Tests
Build 16418: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 3 2020, 13:10
This revision was automatically updated to reflect the committed changes.