Page MenuHomePhabricator

Merge #12917: qa: Windows fixups for functional tests
ClosedPublic

Authored by markblundeberg on Thu, Feb 6, 02:06.

Details

Summary

PR12917 backport.

fab9095d40 qa: Windows fixups for functional tests (MarcoFalke)

Pull request description:

Just two minor fixups to have less errors when the tests run on native windows.
* Strip whitespace from lines when reading from a notification file
* Instead of clumsily creating a file with weird permissions, just create a folder for the same effect in `mempool_persist.py`
Test Plan

ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Thu, Feb 6, 02:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Feb 6, 02:06
teamcity edited the summary of this revision. (Show Details)Thu, Feb 6, 02:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Thu, Feb 6, 02:11
This revision is now accepted and ready to land.Thu, Feb 6, 02:11

This is rerunning on the highperf3 machine...

markblundeberg edited the test plan for this revision. (Show Details)Thu, Feb 6, 02:20