Page MenuHomePhabricator
Differential D5169

Merge #12917: qa: Windows fixups for functional tests
ClosedPublic
Actions

Authored by markblundeberg on Feb 6 2020, 02:06.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING037df0aab738: Merge #12917: qa: Windows fixups for functional tests
rABC037df0aab738: Merge #12917: qa: Windows fixups for functional tests
Summary

PR12917 backport.

fab9095d40 qa: Windows fixups for functional tests (MarcoFalke)

Pull request description:

Just two minor fixups to have less errors when the tests run on native windows.
* Strip whitespace from lines when reading from a notification file
* Instead of clumsily creating a file with weird permissions, just create a folder for the same effect in `mempool_persist.py`
Test Plan

ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12917
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9288
Build 16513: Default Diff Build & Tests
Build 16512: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Feb 6 2020, 02:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 6 2020, 02:06
teamcity edited the summary of this revision. (Show Details)Feb 6 2020, 02:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 6 2020, 02:06

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg added a comment.Feb 6 2020, 02:10

I don't have windows but it should help to fix this problem: https://build.bitcoinabc.org/viewLog.html?buildId=28175&buildTypeId=BitcoinABC_Master_BitcoinAbcMasterAsan&tab=buildResultsDiv

Harbormaster completed remote builds in B9288: Diff 16050.Feb 6 2020, 02:10
teamcity added a comment.Feb 6 2020, 02:10

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix accepted this revision.Feb 6 2020, 02:11
This revision is now accepted and ready to land.Feb 6 2020, 02:11
teamcity added a comment.Feb 6 2020, 02:11

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg added a comment.Feb 6 2020, 02:12
In D5169#124866, @teamcity wrote:

Build Bitcoin-ABC / Diffs / Diff Testing started.

This is rerunning on the highperf3 machine...

teamcity added a comment.Feb 6 2020, 02:18

Build Bitcoin-ABC / Diffs / Diff Testing passed.

markblundeberg edited the test plan for this revision. (Show Details)Feb 6 2020, 02:20
Closed by commit rABC037df0aab738: Merge #12917: qa: Windows fixups for functional tests (authored by MarcoFalke <falke.marco@gmail.com>, committed by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyFeb 6 2020, 02:23
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC037df0aab738: Merge #12917: qa: Windows fixups for functional tests.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING037df0aab738: Merge #12917: qa: Windows fixups for functional tests.Apr 7 2020, 22:49

Revision Contents
Changeset List

PathSize
test/
functional/
9 lines
7 lines

Diff 16050

View Options

test/functional/feature_notifications.py

Loading...
View Options

test/functional/mempool_persist.py

Loading...