Page MenuHomePhabricator

Merge #14958: qa: Remove race between connecting and shutdown on separate connections
ClosedPublic

Authored by markblundeberg on Thu, Feb 6, 04:32.

Details

Summary

PR14958 backport, fixup to D5170

4412a59bfe8228698e5b5bbe8bb21c8e8a70d357 qa: Remove race between connecting and shutdown on separate connections (João Barbosa)

Pull request description:

Fixes the error https://github.com/bitcoin/bitcoin/pull/14670#issuecomment-447255352 reported by @ken2812221.

There is a race between RPC stop and another concurrent call in the test framework. The connection must be established and the command `waitfornewblock` running before calling `stop`.

See also https://github.com/bitcoin/bitcoin/pull/14670#issuecomment-447304513.

Depends on D5170 and D5173

Test Plan

ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Thu, Feb 6, 04:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Feb 6, 04:32
teamcity edited the summary of this revision. (Show Details)Thu, Feb 6, 04:33

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Fabien accepted this revision.Thu, Feb 6, 07:59
This revision is now accepted and ready to land.Thu, Feb 6, 07:59