Page MenuHomePhabricator
Differential D5174

Merge #14958: qa: Remove race between connecting and shutdown on separate connections
ClosedPublic
Actions

Authored by markblundeberg on Feb 6 2020, 04:32.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING66eda510af82: Merge #14958: qa: Remove race between connecting and shutdown on separate…
rABC66eda510af82: Merge #14958: qa: Remove race between connecting and shutdown on separate…
Summary

PR14958 backport, fixup to D5170

4412a59bfe8228698e5b5bbe8bb21c8e8a70d357 qa: Remove race between connecting and shutdown on separate connections (João Barbosa)

Pull request description:

Fixes the error https://github.com/bitcoin/bitcoin/pull/14670#issuecomment-447255352 reported by @ken2812221.

There is a race between RPC stop and another concurrent call in the test framework. The connection must be established and the command `waitfornewblock` running before calling `stop`.

See also https://github.com/bitcoin/bitcoin/pull/14670#issuecomment-447304513.

Depends on D5170 and D5173

Test Plan

ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.Feb 6 2020, 04:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 6 2020, 04:32
teamcity edited the summary of this revision. (Show Details)Feb 6 2020, 04:33

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 6 2020, 04:33

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg mentioned this in D5170: Merge #14670: http: Fix HTTP server shutdown.Feb 6 2020, 04:34
teamcity added a comment.Feb 6 2020, 04:50

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9293: Diff 16058.Feb 6 2020, 04:50
Fabien accepted this revision.Feb 6 2020, 07:59
This revision is now accepted and ready to land.Feb 6 2020, 07:59
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rABC35f2c83fa670: Merge #14670: http: Fix HTTP server shutdown.Feb 6 2020, 08:14
Closed by commit rABC66eda510af82: Merge #14958: qa: Remove race between connecting and shutdown on separate… (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyFeb 6 2020, 08:16
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC66eda510af82: Merge #14958: qa: Remove race between connecting and shutdown on separate….
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING66eda510af82: Merge #14958: qa: Remove race between connecting and shutdown on separate….Apr 7 2020, 22:50
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rSTAGING35f2c83fa670: Merge #14670: http: Fix HTTP server shutdown.

Revision Contents
Changeset List

PathSize
test/
functional/
11 lines

Diff 16065

View Options

test/functional/feature_shutdown.py

Loading...