Page MenuHomePhabricator
Differential D5171

Merge #15350: qa: Drop RPC connection if --usecli
ClosedPublic
Actions

Authored by markblundeberg on Feb 6 2020, 04:00.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING6afabe7b7152: Merge #15350: qa: Drop RPC connection if --usecli
rABC6afabe7b7152: Merge #15350: qa: Drop RPC connection if --usecli
Summary

PR15350 Backport. Fixes --usecli slowdown from D5170 .

6440e61375 qa: Drop RPC connection if --usecli (João Barbosa)

Pull request description:

Drop the RPC connection used in `TestNode.wait_for_rpc_connection` if `--usecli` is set. If the connection is kept and not used the `Connection: close` header is never sent and so the connection only closes due to timeout (30 sec).

It might be sensible to revert e98a9eede2fb48ff33a020acc888cbcd83e24bbf in a follow up, however it changes the shutdown behavior.

Depends on D5170.

Test Plan

ninja check-all ; observe --cli tests aren't particularly slow compared to their normal counterparts

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.Feb 6 2020, 04:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 6 2020, 04:00
teamcity edited the summary of this revision. (Show Details)Feb 6 2020, 04:00

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 6 2020, 04:00

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 6 2020, 04:05

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9290: Diff 16055.Feb 6 2020, 04:05
markblundeberg mentioned this in D5170: Merge #14670: http: Fix HTTP server shutdown.Feb 6 2020, 04:34
Fabien accepted this revision.Feb 6 2020, 07:47
This revision is now accepted and ready to land.Feb 6 2020, 07:47
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rABC35f2c83fa670: Merge #14670: http: Fix HTTP server shutdown.Feb 6 2020, 08:14
Closed by commit rABC6afabe7b7152: Merge #15350: qa: Drop RPC connection if --usecli (authored by MarcoFalke <falke.marco@gmail.com>, committed by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyFeb 6 2020, 08:22
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC6afabe7b7152: Merge #15350: qa: Drop RPC connection if --usecli.
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rSTAGING35f2c83fa670: Merge #14670: http: Fix HTTP server shutdown.Apr 7 2020, 22:50
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING6afabe7b7152: Merge #15350: qa: Drop RPC connection if --usecli.

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
11 lines

Diff 16066

View Options

test/functional/test_framework/test_node.py

Loading...