Page MenuHomePhabricator
Differential D5173

Merge #14982: rpc: Add getrpcinfo command
ClosedPublic
Actions

Authored by markblundeberg on Feb 6 2020, 04:30.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING8529062d29ba: Merge #14982: rpc: Add getrpcinfo command
rABC8529062d29ba: Merge #14982: rpc: Add getrpcinfo command
Summary

PR14982 backport.

a0ac15459a0df598e1ee1fd36a3899a129cecaeb doc: Add getrpcinfo release notes (João Barbosa)
251a91c1bf245b3674c2612149382a0f1e18dc98 qa: Add tests for getrpcinfo (João Barbosa)
d0730f5ce475e5a84da7c61fe79bcd6ed24d693e rpc: Add getrpcinfo command (João Barbosa)
068a8fc05f8dbec198bdc3fe46f955d8a5255303 rpc: Track active commands (João Barbosa)
bf4383277d6761cc5b7a91975752c08df829af72 rpc: Remove unused PreCommand signal (João Barbosa)

Pull request description:

The new `getrpcinfo` command exposes details of the RPC interface. The details can be configuration properties or runtime values/stats.

This can be particular useful to coordinate concurrent functional tests (see #14958 from where this was extracted).

Backport note: includes some boilerplate changes to getrpcinfo()
code (we don't have RPCHelpMan yet).

Depends on D5172

Test Plan

ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.Feb 6 2020, 04:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 6 2020, 04:30
teamcity edited the summary of this revision. (Show Details)Feb 6 2020, 04:30

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 6 2020, 04:30

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg added a child revision: D5174: Merge #14958: qa: Remove race between connecting and shutdown on separate connections.Feb 6 2020, 04:32
teamcity added a comment.Feb 6 2020, 04:35

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9292: Diff 16057.Feb 6 2020, 04:35
Fabien accepted this revision.Feb 6 2020, 07:57
This revision is now accepted and ready to land.Feb 6 2020, 07:57
Closed by commit rABC8529062d29ba: Merge #14982: rpc: Add getrpcinfo command (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyFeb 6 2020, 08:16
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC8529062d29ba: Merge #14982: rpc: Add getrpcinfo command.
nakihito mentioned this in D5548: Partial Merge #14726: Use RPCHelpMan for all RPCs.Mar 23 2020, 19:55
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING8529062d29ba: Merge #14982: rpc: Add getrpcinfo command.Apr 7 2020, 22:50

Revision Contents
Changeset List

PathSize
doc/
3 lines
src/
rpc/
54 lines
test/
functional/
13 lines

Diff 16064

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/server.cpp

Loading...
View Options

test/functional/interface_rpc.py

Loading...