Page MenuHomePhabricator

Merge #15350: qa: Drop RPC connection if --usecli
ClosedPublic

Authored by markblundeberg on Feb 6 2020, 04:00.

Details

Summary

PR15350 Backport. Fixes --usecli slowdown from D5170 .

6440e61375 qa: Drop RPC connection if --usecli (João Barbosa)

Pull request description:

Drop the RPC connection used in `TestNode.wait_for_rpc_connection` if `--usecli` is set. If the connection is kept and not used the `Connection: close` header is never sent and so the connection only closes due to timeout (30 sec).

It might be sensible to revert e98a9eede2fb48ff33a020acc888cbcd83e24bbf in a follow up, however it changes the shutdown behavior.

Depends on D5170.

Test Plan

ninja check-all ; observe --cli tests aren't particularly slow compared to their normal counterparts

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15350
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9290
Build 16517: Default Diff Build & Tests
Build 16516: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Feb 6 2020, 07:47