Page MenuHomePhabricator
Differential D5185

Merge #14179: qa: Fixups to "Run all tests even if wallet is not compiled"
ClosedPublic
Actions

Authored by nakihito on Feb 6 2020, 21:50.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGea0cb385d243: Merge #14179: qa: Fixups to "Run all tests even if wallet is not compiled"
rABCea0cb385d243: Merge #14179: qa: Fixups to "Run all tests even if wallet is not compiled"
Summary

fa8433e379 qa: Remove unneded import_deterministic_coinbase_privkeys overwrite, add comments (MarcoFalke)
e413c2ddd1 qa: Fix codespell error and have lint-spelling error instead of warn (MarcoFalke)

Pull request description:

Currently the functional tests require the wallet module to be compiled into the Bitcoin Core executable. For example the premine (or datadir cache) to speed up tests when run in parallel would mine a bunch of blocks and store the private keys to sign the coinbase tx outputs in a wallet. There is no need to have the overhead of the whole wallet module by using keys that are deterministic for all runs.

Note that this change most likely requires the `./test/cache/` to be cleared.

Tree-SHA512: 9ce26036b0e10f0f888f66a1e50be6a357343f9ffb302ae24a7bb3df2f083a31702ef308b738a03b08a1b623aeddac5d6563dc1b15078c0357b7dafad7808ec3

Backport of Core PR14179

Depends on D5184

Test Plan
cmake -GNinja .. -DBUILD_BITCOIN_WALLET=OFF
ninja check
ninja check-functional-extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14179
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9310
Build 16557: Default Diff Build & Tests
Build 16556: arc lint + arc unit

Event Timeline

nakihito created this revision.Feb 6 2020, 21:50
Owners added a reviewer: Restricted Owners Package.Feb 6 2020, 21:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 6 2020, 21:50
nakihito planned changes to this revision.Feb 6 2020, 21:50
teamcity edited the summary of this revision. (Show Details)Feb 6 2020, 21:50

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 6 2020, 21:50

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 6 2020, 22:07

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9310: Diff 16086.Feb 6 2020, 22:07
nakihito requested review of this revision.Feb 6 2020, 22:34
jasonbcox accepted this revision.Feb 7 2020, 02:14
This revision is now accepted and ready to land.Feb 7 2020, 02:14
Closed by commit rABCea0cb385d243: Merge #14179: qa: Fixups to "Run all tests even if wallet is not compiled" (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyFeb 7 2020, 18:34
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCea0cb385d243: Merge #14179: qa: Fixups to "Run all tests even if wallet is not compiled".
nakihito added a commit: rSTAGINGea0cb385d243: Merge #14179: qa: Fixups to "Run all tests even if wallet is not compiled".Apr 7 2020, 22:54

Revision Contents
Changeset List

PathSize
test/
functional/
17 lines
6 lines
2 lines

Diff 16086

View Options

test/functional/interface_zmq.py

Loading...
View Options

test/functional/wallet_dump.py

Loading...
View Options

test/functional/wallet_import_rescan.py

Loading...