Page MenuHomePhabricator

Merge #14926: test: consensus: Check that final transactions are valid

Authored by markblundeberg on Fri, Feb 7, 10:50.



PR14926 backport.

Pull request description:

There is no check that checks that final transactions are valid, i.e. the consensus rules could be changed (accidentally) with none of the tests failing.
Test Plan

ninja check-all

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Fri, Feb 7, 10:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Feb 7, 10:50
teamcity edited the summary of this revision. (Show Details)Fri, Feb 7, 10:50

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Fabien accepted this revision.Fri, Feb 7, 10:59
Fabien added a subscriber: Fabien.

Only nits

96 ↗(On Diff #16097)

Nit: Put comment on its own line

103 ↗(On Diff #16097)

Nit: tx = FromHex(tx, raw_tx_final). Note that this is also valid for the above occurrence but out of scope.

106 ↗(On Diff #16097)

Nit: rawtxs=[ToHex(tx)]

This revision is now accepted and ready to land.Fri, Feb 7, 10:59