Merge #14926: test: consensus: Check that final transactions are valid
ClosedPublic
Actions

Authored by markblundeberg on Feb 7 2020, 10:50.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGb695dd718e58: Merge #14926: test: consensus: Check that final transactions are valid
rABCb695dd718e58: Merge #14926: test: consensus: Check that final transactions are valid

Summary

PR14926 backport.

Pull request description:

There is no check that checks that final transactions are valid, i.e. the consensus rules could be changed (accidentally) with none of the tests failing.

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markblundeberg created this revision.Feb 7 2020, 10:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 7 2020, 10:50

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg added a child revision: D5190: Merge #14964: test: Fix race in mempool_accept.Feb 7 2020, 10:52

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9316: Diff 16097.Feb 7 2020, 10:55

Only nits

test/functional/mempool_accept.py
96 ↗	(On Diff #16097)	Nit: Put comment on its own line
103 ↗	(On Diff #16097)	Nit: `tx = FromHex(tx, raw_tx_final)`. Note that this is also valid for the above occurrence but out of scope.
106 ↗	(On Diff #16097)	Nit: `rawtxs=[ToHex(tx)]`