Page MenuHomePhabricator

Merge #14926: test: consensus: Check that final transactions are valid
ClosedPublic

Authored by markblundeberg on Feb 7 2020, 10:50.

Details

Summary

PR14926 backport.

Pull request description:

There is no check that checks that final transactions are valid, i.e. the consensus rules could be changed (accidentally) with none of the tests failing.
Test Plan

ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Fabien added a subscriber: Fabien.

Only nits

test/functional/mempool_accept.py
96 ↗(On Diff #16097)

Nit: Put comment on its own line

103 ↗(On Diff #16097)

Nit: tx = FromHex(tx, raw_tx_final). Note that this is also valid for the above occurrence but out of scope.

106 ↗(On Diff #16097)

Nit: rawtxs=[ToHex(tx)]

This revision is now accepted and ready to land.Feb 7 2020, 10:59