Page MenuHomePhabricator
Differential D5190

Merge #14964: test: Fix race in mempool_accept
ClosedPublic
Actions

Authored by markblundeberg on Feb 7 2020, 10:52.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGd88a2c45b5cc: Merge #14964: test: Fix race in mempool_accept
rABCd88a2c45b5cc: Merge #14964: test: Fix race in mempool_accept
Summary

PR14964 backport

Pull request description:

If we happen to pick the same random coin to spend, there would be mempool conflicts in some runs of the test. Fix that by popping from a static list of coins to spend from.

Depends on D5189

Test Plan

ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.Feb 7 2020, 10:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 7 2020, 10:52
teamcity edited the summary of this revision. (Show Details)Feb 7 2020, 10:52

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 7 2020, 10:52

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B9317: Diff 16098.Feb 7 2020, 10:59
teamcity added a comment.Feb 7 2020, 10:59

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien accepted this revision.Feb 7 2020, 11:02
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/mempool_accept.py
66 ↗(On Diff #16098)

Move comment above

97 ↗(On Diff #16098)

Dito

This revision is now accepted and ready to land.Feb 7 2020, 11:02
Closed by commit rABCd88a2c45b5cc: Merge #14964: test: Fix race in mempool_accept (authored by MarcoFalke <falke.marco@gmail.com>, committed by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyFeb 7 2020, 11:56
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABCd88a2c45b5cc: Merge #14964: test: Fix race in mempool_accept.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGINGd88a2c45b5cc: Merge #14964: test: Fix race in mempool_accept.Apr 7 2020, 22:52

Revision Contents
Changeset List

PathSize
test/
functional/
7 lines

Diff 16107

View Options

test/functional/mempool_accept.py

Loading...