Page MenuHomePhabricator

Merge #14964: test: Fix race in mempool_accept
ClosedPublic

Authored by markblundeberg on Fri, Feb 7, 10:52.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd88a2c45b5cc: Merge #14964: test: Fix race in mempool_accept
Summary

PR14964 backport

Pull request description:

If we happen to pick the same random coin to spend, there would be mempool conflicts in some runs of the test. Fix that by popping from a static list of coins to spend from.

Depends on D5189

Test Plan

ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Fri, Feb 7, 10:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Feb 7, 10:52
teamcity edited the summary of this revision. (Show Details)Fri, Feb 7, 10:52

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Fabien accepted this revision.Fri, Feb 7, 11:02
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/mempool_accept.py
66 ↗(On Diff #16098)

Move comment above

97 ↗(On Diff #16098)

Dito

This revision is now accepted and ready to land.Fri, Feb 7, 11:02