Page MenuHomePhabricator

Merge #14964: test: Fix race in mempool_accept
ClosedPublic

Authored by markblundeberg on Feb 7 2020, 10:52.

Details

Summary

PR14964 backport

Pull request description:

If we happen to pick the same random coin to spend, there would be mempool conflicts in some runs of the test. Fix that by popping from a static list of coins to spend from.

Depends on D5189

Test Plan

ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/mempool_accept.py
66 ↗(On Diff #16098)

Move comment above

97 ↗(On Diff #16098)

Dito

This revision is now accepted and ready to land.Feb 7 2020, 11:02