Page MenuHomePhabricator
Differential D5202

[python linting] enforce E713: Test for membership should be 'not in'
ClosedPublic
Actions

Authored by markblundeberg on Feb 7 2020, 15:21.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING5e840de1ed98: [python linting] enforce E713: Test for membership should be 'not in'
rABC5e840de1ed98: [python linting] enforce E713: Test for membership should be 'not in'
Summary

Depends on D5200

Test Plan

ninja check-all
arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Branch
lintfixes
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9330
Build 16596: Default Diff Build & Tests
Build 16595: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Feb 7 2020, 15:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 7 2020, 15:21
teamcity added a comment.Feb 7 2020, 15:22

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 7 2020, 15:27

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9330: Diff 16118.Feb 7 2020, 15:27
Fabien accepted this revision.Feb 7 2020, 15:28
This revision is now accepted and ready to land.Feb 7 2020, 15:28
markblundeberg added a child revision: D5204: [python linting] enforce E731: Do not assign a lambda expression, use a def.Feb 7 2020, 15:30
Closed by commit rABC5e840de1ed98: [python linting] enforce E713: Test for membership should be 'not in' (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyFeb 7 2020, 15:57
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC5e840de1ed98: [python linting] enforce E713: Test for membership should be 'not in'.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING5e840de1ed98: [python linting] enforce E713: Test for membership should be 'not in'.Apr 7 2020, 22:52

Revision Contents
Changeset List

PathSize
2 lines
contrib/
devtools/
2 lines
4 lines
linearize/
2 lines
test/
functional/
2 lines
2 lines

Diff 16118

View Options

.arclint

Loading...
View Options

contrib/devtools/symbol-check.py

Loading...
View Options

contrib/gitian-build.py

Loading...
View Options

contrib/linearize/linearize-data.py

Loading...
View Options

test/functional/test_runner.py

Loading...
View Options

test/functional/wallet_abandonconflict.py

Loading...