Page MenuHomePhabricator
Differential D5204

[python linting] enforce E731: Do not assign a lambda expression, use a def
ClosedPublic
Actions

Authored by markblundeberg on Feb 7 2020, 15:30.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGf18bb7d1cf1e: [python linting] enforce E731: Do not assign a lambda expression, use a def
rABCf18bb7d1cf1e: [python linting] enforce E731: Do not assign a lambda expression, use a def
Summary

Depends on D5202

Test Plan

./test/functional/test_runner.py wallet_multiwallet
arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Branch
lintfixes
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9332
Build 16600: Default Diff Build & Tests
Build 16599: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Feb 7 2020, 15:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 7 2020, 15:30
teamcity added a comment.Feb 7 2020, 15:30

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 7 2020, 15:35

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9332: Diff 16120.Feb 7 2020, 15:35
markblundeberg added inline comments.Feb 7 2020, 15:37
test/functional/wallet_multiwallet.py
29

note: this one line function style would be blocked by E704 but it seems to be a prevalent violation...

deadalnix accepted this revision.Feb 7 2020, 16:19
This revision is now accepted and ready to land.Feb 7 2020, 16:19
Closed by commit rABCf18bb7d1cf1e: [python linting] enforce E731: Do not assign a lambda expression, use a def (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyFeb 7 2020, 16:23
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABCf18bb7d1cf1e: [python linting] enforce E731: Do not assign a lambda expression, use a def.
markblundeberg added a child revision: D5208: [python linting] enforce E722: do not use bare except.Feb 7 2020, 17:38
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGINGf18bb7d1cf1e: [python linting] enforce E731: Do not assign a lambda expression, use a def.Apr 7 2020, 22:52

Revision Contents
Changeset List

PathSize
2 lines
test/
functional/
5 lines

Diff 16120

View Options

.arclint

Loading...
View Options

test/functional/wallet_multiwallet.py

Loading...