Page MenuHomePhabricator

Use a temporary datadir and non-default RPC port when testing seeds
ClosedPublic

Authored by jasonbcox on Mon, Feb 10, 23:10.

Details

Summary

This makes it far less likely to interfere with any nodes that may already be running.

Test Plan
bitcoind  # running a node should not cause any issues post-patch
./test-seeds.sh < nodes_main.txt
./test-seeds.sh --testnet < nodes_test.txt
../teamcity/check-seeds.sh main 80
../teamcity/check-seeds.sh test 80

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Mon, Feb 10, 23:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Feb 10, 23:10
jasonbcox planned changes to this revision.Mon, Feb 10, 23:33
jasonbcox requested review of this revision.
jasonbcox edited the test plan for this revision. (Show Details)Tue, Feb 11, 00:25
Fabien accepted this revision.Tue, Feb 11, 10:31
Fabien added a subscriber: Fabien.
Fabien added inline comments.
contrib/seeds/test-seeds.sh
63 ↗(On Diff #16238)

Note to reviewers: testnet default is 18332.

This revision is now accepted and ready to land.Tue, Feb 11, 10:31