Page MenuHomePhabricator
Differential D5248

Add update-seeds to automated-commits
ClosedPublic
Actions

Authored by jasonbcox on Feb 10 2020, 23:52.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGd5771bf781e3: Add update-seeds to automated-commits
rABCd5771bf781e3: Add update-seeds to automated-commits
Summary

This will allow us to automatically update seeds and detangle it from our release process.

Depends on D5246 and D5331

Test Plan
curl seederdump.bitframe.org/seeds_main.txt > ~/Downloads/seeds_main.txt
curl seederdump.bitframe.org/seeds_test.txt > ~/Downloads/seeds_test.txt
SEEDS_MAIN=~/Downloads/seeds_main.txt SEEDS_TEST=~/Downloads/seeds_test.txt COMMIT_TYPE=update-seeds ./automated-commits.sh  # dry-run

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Feb 10 2020, 23:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 10 2020, 23:52
teamcity added a comment.Feb 10 2020, 23:53

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox planned changes to this revision.Feb 10 2020, 23:53
teamcity added a comment.Feb 11 2020, 00:02

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9407: Diff 16244.Feb 11 2020, 00:02
jasonbcox updated this revision to Diff 16496.Feb 25 2020, 19:54
  • Rebase
  • Decouple dependencies from CI
teamcity added a comment.Feb 25 2020, 19:54

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 25 2020, 20:04

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9564: Diff 16496.Feb 25 2020, 20:04
Fabien requested changes to this revision.Feb 25 2020, 20:26
Fabien added a subscriber: Fabien.
Fabien added inline comments.
contrib/source-control-tools/automated-commits.sh
106 ↗(On Diff #16496)

makeseeds is executable and has a shebang, so you can avoid calling it using python3.

121 ↗(On Diff #16496)

You need to build first

This revision now requires changes to proceed.Feb 25 2020, 20:26
jasonbcox added a child revision: D5330: Add update-manpages to automated-commits.Feb 25 2020, 23:40
jasonbcox updated this revision to Diff 16515.Feb 26 2020, 00:33

Fixed build and addressed feedback

jasonbcox edited the summary of this revision. (Show Details)Feb 26 2020, 00:33
jasonbcox added a parent revision: D5331: [automated-commits] Make sure BUILD_DIR exists and is exported.
teamcity added a comment.Feb 26 2020, 00:33

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 26 2020, 00:43

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9576: Diff 16515.Feb 26 2020, 00:43
Fabien accepted this revision.Feb 26 2020, 15:08
This revision is now accepted and ready to land.Feb 26 2020, 15:08
Closed by commit rABCd5771bf781e3: Add update-seeds to automated-commits (authored by jasonbcox). · Explain WhyFeb 26 2020, 17:27
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCd5771bf781e3: Add update-seeds to automated-commits.
jasonbcox mentioned this in D5336: Update seeds.Feb 26 2020, 22:37
jasonbcox mentioned this in rABCa581801f3ce0: Update seeds.Feb 27 2020, 17:52
jasonbcox added a commit: rSTAGINGd5771bf781e3: Add update-seeds to automated-commits.Apr 7 2020, 23:06
jasonbcox mentioned this in rSTAGINGa581801f3ce0: Update seeds.

Revision Contents
Changeset List

PathSize
contrib/
source-control-tools/
26 lines

Diff 16525

View Options

contrib/source-control-tools/automated-commits.sh

Loading...