Page MenuHomePhabricator
Differential D5246

Use a temporary datadir and non-default RPC port when testing seeds
ClosedPublic
Actions

Authored by jasonbcox on Feb 10 2020, 23:10.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING5b6f369672e7: Use a temporary datadir and non-default RPC port when testing seeds
rABC5b6f369672e7: Use a temporary datadir and non-default RPC port when testing seeds
Summary

This makes it far less likely to interfere with any nodes that may already be running.

Test Plan
bitcoind  # running a node should not cause any issues post-patch
./test-seeds.sh < nodes_main.txt
./test-seeds.sh --testnet < nodes_test.txt
../teamcity/check-seeds.sh main 80
../teamcity/check-seeds.sh test 80

Diff Detail

Repository
rABC Bitcoin ABC
Branch
tmp-test-seeds
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9402
Build 16734: Default Diff Build & Tests
Build 16733: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Feb 10 2020, 23:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 10 2020, 23:10
teamcity added a comment.Feb 10 2020, 23:11

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B9402: Diff 16238.Feb 10 2020, 23:20
teamcity added a comment.Feb 10 2020, 23:20

Build Bitcoin-ABC / Diffs / Diff Testing passed.

jasonbcox planned changes to this revision.Feb 10 2020, 23:33
jasonbcox requested review of this revision.
jasonbcox added a child revision: D5248: Add update-seeds to automated-commits.Feb 10 2020, 23:52
jasonbcox edited the test plan for this revision. (Show Details)Feb 11 2020, 00:25
Fabien accepted this revision.Feb 11 2020, 10:31
Fabien added a subscriber: Fabien.
Fabien added inline comments.
contrib/seeds/test-seeds.sh
63

Note to reviewers: testnet default is 18332.

This revision is now accepted and ready to land.Feb 11 2020, 10:31
Closed by commit rABC5b6f369672e7: Use a temporary datadir and non-default RPC port when testing seeds (authored by jasonbcox). · Explain WhyFeb 11 2020, 19:37
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC5b6f369672e7: Use a temporary datadir and non-default RPC port when testing seeds.
jasonbcox added a commit: rSTAGING5b6f369672e7: Use a temporary datadir and non-default RPC port when testing seeds.Apr 7 2020, 22:58

Revision Contents
Changeset List

PathSize
contrib/
seeds/
6 lines

Diff 16238

View Options

contrib/seeds/test-seeds.sh

Loading...