Page MenuHomePhabricator

Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC
ClosedPublic

Authored by nakihito on Feb 12 2020, 23:24.

Details

Summary

14a06525b2 tests: add test for 'getaddressinfo' RPC result 'ischange' field (whythat)
93d1aa9abc rpcwallet: add 'ischange' field to 'getaddressinfo' response (whythat)

Pull request description:

Implementation of proposal in #14396.

This introduces `CWallet::IsChange(CScript&)` method and replaces original `CWallet::IsChange(CTxOut&)` method with overloaded version that delegates to the new method with *txout*'s `scriptPubKey`. In this way `TODO` note from the original method can still be addressed in a single place.

Tree-SHA512: ef5dbc82d76b4b9b2fa6a70abc3385a677c55021f79e187ee2f392ee32bc6b406191f4129acae5c17b0206e72b6712e7e0cad574a4bbd966871c2e656c45e041

Backport of Core PR14410
https://github.com/bitcoin/bitcoin/pull/14410/

Test Plan
ninja check
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14410
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9468
Build 16852: Default Diff Build & Tests
Build 16851: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Feb 12 2020, 23:24

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Feb 13 2020, 09:40