Page MenuHomePhabricator
Differential D5280

Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC
ClosedPublic
Actions

Authored by nakihito on Feb 12 2020, 23:24.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING30527d21d9fe: Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC
rABC30527d21d9fe: Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC
Summary

14a06525b2 tests: add test for 'getaddressinfo' RPC result 'ischange' field (whythat)
93d1aa9abc rpcwallet: add 'ischange' field to 'getaddressinfo' response (whythat)

Pull request description:

Implementation of proposal in #14396.

This introduces `CWallet::IsChange(CScript&)` method and replaces original `CWallet::IsChange(CTxOut&)` method with overloaded version that delegates to the new method with *txout*'s `scriptPubKey`. In this way `TODO` note from the original method can still be addressed in a single place.

Tree-SHA512: ef5dbc82d76b4b9b2fa6a70abc3385a677c55021f79e187ee2f392ee32bc6b406191f4129acae5c17b0206e72b6712e7e0cad574a4bbd966871c2e656c45e041

Backport of Core PR14410
https://github.com/bitcoin/bitcoin/pull/14410/

Test Plan
ninja check
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14410
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9468
Build 16852: Default Diff Build & Tests
Build 16851: arc lint + arc unit

Event Timeline

nakihito created this revision.Feb 12 2020, 23:24
Owners added a reviewer: Restricted Owners Package.Feb 12 2020, 23:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 12 2020, 23:24
teamcity edited the summary of this revision. (Show Details)Feb 12 2020, 23:24

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 12 2020, 23:24

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 12 2020, 23:34

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9468: Diff 16336.Feb 12 2020, 23:34
Fabien accepted this revision.Feb 13 2020, 09:40
This revision is now accepted and ready to land.Feb 13 2020, 09:40
Closed by commit rABC30527d21d9fe: Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyFeb 13 2020, 19:44
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC30527d21d9fe: Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC.
nakihito added a commit: rSTAGING30527d21d9fe: Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC.Apr 7 2020, 23:00

Revision Contents
Changeset List

PathSize
doc/
2 lines
src/
wallet/
3 lines
1 line
8 lines
test/
functional/
22 lines

Diff 16336

View Options

doc/release-notes.md

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

test/functional/wallet_basic.py

Loading...