Page MenuHomePhabricator
Differential D5310

Mute self assign warning in uint256_tests.cpp
ClosedPublic
Actions

Authored by deadalnix on Feb 21 2020, 00:12.

Details

Reviewers
jasonbcox
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGfbc8207e5395: Mute self assign warning in uint256_tests.cpp
rABCfbc8207e5395: Mute self assign warning in uint256_tests.cpp
Summary

While it is generaly a bad idea to do so, we want to test that the code behave properly if someone came to do this anyways. So we remove the warning using a noop.

Test Plan
ninja check

Verify that the warnings are gone.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Feb 21 2020, 00:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 21 2020, 00:12
teamcity added a comment.Feb 21 2020, 00:13

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 21 2020, 00:22

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9533: Diff 16449.Feb 21 2020, 00:22
deadalnix retitled this revision from Must self assign warning in uint256_tests.cpp to Mute self assign warning in uint256_tests.cpp.Feb 21 2020, 01:57
jasonbcox accepted this revision.Feb 21 2020, 04:16
jasonbcox added a subscriber: jasonbcox.

Nifty solution.

This revision is now accepted and ready to land.Feb 21 2020, 04:16
Fabien accepted this revision.Feb 21 2020, 07:14
Closed by commit rABCfbc8207e5395: Mute self assign warning in uint256_tests.cpp (authored by deadalnix). · Explain WhyFeb 23 2020, 23:34
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCfbc8207e5395: Mute self assign warning in uint256_tests.cpp.
deadalnix added a commit: rSTAGINGfbc8207e5395: Mute self assign warning in uint256_tests.cpp.Apr 7 2020, 23:04

Revision Contents
Changeset List

PathSize
src/
test/
11 lines

Diff 16469

View Options

src/test/uint256_tests.cpp

Loading...