Page MenuHomePhabricator
Differential D5575

[CMAKE] Pull miniupnpc windows library dependencies in the find module
ClosedPublic
Actions

Authored by Fabien on Mar 26 2020, 16:27.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING28626adf58a0: [CMAKE] Pull miniupnpc windows library dependencies in the find module
rABC28626adf58a0: [CMAKE] Pull miniupnpc windows library dependencies in the find module
Summary

This is quite identical to what is done with libevent. It prevents from
managing the dependencies at the project level.

The definitions are kept at project level since there are assuming that
we build using the depends, which should always be the case for now but
is not a library requirement. A comment is added to explain this.

Depends on D5576.

Test Plan

Build for windows. Run the binaries and check the UPnP functions are
available.

Run the windows Gitian build.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_miniupnpc_iphlpapi
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9985
Build 17818: Default Diff Build & Tests
Build 17817: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 26 2020, 16:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 26 2020, 16:27
teamcity added a comment.Mar 26 2020, 16:27

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 26 2020, 16:40

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9984: Diff 17205.Mar 26 2020, 16:40
Fabien updated this revision to Diff 17207.Mar 26 2020, 16:52

Fix typo.

teamcity added a comment.Mar 26 2020, 16:52

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien planned changes to this revision.Mar 26 2020, 16:56

Will add a facility to find_component since I have to do the same for ZMQ as well.

teamcity added a comment.Mar 26 2020, 17:01

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9985: Diff 17207.Mar 26 2020, 17:02
Fabien updated this revision to Diff 17209.Mar 26 2020, 17:08

Rebase on top of D5576.

teamcity added a comment.Mar 26 2020, 17:08

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien edited the summary of this revision. (Show Details)Mar 26 2020, 17:09
Fabien added a parent revision: D5576: [CMAKE] Pass the interface linked libraries to find_component.
teamcity added a comment.Mar 26 2020, 17:18

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) started.

Harbormaster completed remote builds in B9987: Diff 17209.Mar 26 2020, 17:21
teamcity added a comment.Mar 26 2020, 17:21

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

teamcity added a comment.Mar 26 2020, 17:34

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) passed.

jasonbcox accepted this revision.Mar 26 2020, 20:35
This revision is now accepted and ready to land.Mar 26 2020, 20:35
Closed by commit rABC28626adf58a0: [CMAKE] Pull miniupnpc windows library dependencies in the find module (authored by Fabien). · Explain WhyMar 27 2020, 17:27
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC28626adf58a0: [CMAKE] Pull miniupnpc windows library dependencies in the find module.
Fabien added a commit: rSTAGING28626adf58a0: [CMAKE] Pull miniupnpc windows library dependencies in the find module.Apr 7 2020, 23:31

Revision Contents
Changeset List

PathSize
cmake/
modules/
6 lines
src/
9 lines

Diff 17207

View Options

cmake/modules/FindMiniUPnPc.cmake

Loading...
View Options

src/CMakeLists.txt

Loading...