Page MenuHomePhabricator

[CMAKE] Pull miniupnpc windows library dependencies in the find module
ClosedPublic

Authored by Fabien on Mar 26 2020, 16:27.

Details

Summary

This is quite identical to what is done with libevent. It prevents from
managing the dependencies at the project level.

The definitions are kept at project level since there are assuming that
we build using the depends, which should always be the case for now but
is not a library requirement. A comment is added to explain this.

Depends on D5576.

Test Plan

Build for windows. Run the binaries and check the UPnP functions are
available.

Run the windows Gitian build.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_miniupnpc_iphlpapi
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9985
Build 17818: Default Diff Build & Tests
Build 17817: arc lint + arc unit

Event Timeline

Fabien planned changes to this revision.Mar 26 2020, 16:56

Will add a facility to find_component since I have to do the same for ZMQ as well.

This revision is now accepted and ready to land.Mar 26 2020, 20:35