Differential D5676

Pass CChainParams down to UpdateTip
ClosedPublic
Actions

Authored by deadalnix on Apr 4 2020, 23:07.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING9864e9884d36: Pass CChainParams down to UpdateTip
rABC9864e9884d36: Pass CChainParams down to UpdateTip

Summary

The config is overkill.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

UpdateTipChainParams

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10131
Build 18089: Default Diff Build & Tests
Build 18088: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 4 2020, 23:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 4 2020, 23:07

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10131: Diff 17454.Apr 4 2020, 23:17

Fabien accepted this revision.Apr 6 2020, 13:26

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/validation.cpp
2370	params

This revision is now accepted and ready to land.Apr 6 2020, 13:26

Closed by commit rABC9864e9884d36: Pass CChainParams down to UpdateTip (authored by deadalnix). · Explain WhyApr 6 2020, 15:39

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC9864e9884d36: Pass CChainParams down to UpdateTip.

deadalnix added a commit: rSTAGING9864e9884d36: Pass CChainParams down to UpdateTip.Apr 7 2020, 21:51

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

30 lines

Diff 17454

View Options

Pass CChainParams down to UpdateTipClosedPublicActions