Page MenuHomePhabricator

[avalanche] Poll tip candidate rather than eagerly
ClosedPublic

Authored by deadalnix on Apr 5 2020, 15:51.

Details

Summary

No point in polling for block that may not end up as tip anyways. The next step is to poll all valid blocks.

Depends on D5673

Test Plan

Updated intergration test to reflect that the chain we poll must now be longer.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Apr 5 2020, 15:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 5 2020, 15:51
Fabien requested changes to this revision.Apr 6 2020, 13:43
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/validation.cpp
2843 ↗(On Diff #17456)

You need to filter if the block is invalid as well, there is no need to poll for it.

This revision now requires changes to proceed.Apr 6 2020, 13:43
deadalnix requested review of this revision.Apr 6 2020, 16:17
deadalnix added inline comments.
src/validation.cpp
2843 ↗(On Diff #17456)
Fabien accepted this revision.Apr 7 2020, 07:48
This revision is now accepted and ready to land.Apr 7 2020, 07:48
This revision was landed with ongoing or failed builds.Apr 8 2020, 13:01
This revision was automatically updated to reflect the committed changes.