[avalanche] Poll tip candidate rather than eagerly
ClosedPublic
Actions

Authored by deadalnix on Apr 5 2020, 15:51.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING9c7b12e6f128: [avalanche] Poll tip candidate rather than eagerly
rABC9c7b12e6f128: [avalanche] Poll tip candidate rather than eagerly

Summary

No point in polling for block that may not end up as tip anyways. The next step is to poll all valid blocks.

Depends on D5673

Test Plan

Updated intergration test to reflect that the chain we poll must now be longer.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avapolltip

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10133
Build 18093: Default Diff Build & Tests
Build 18092: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 5 2020, 15:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 5 2020, 15:51

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10133: Diff 17456.Apr 5 2020, 16:01

Fabien requested changes to this revision.Apr 6 2020, 13:43

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/validation.cpp
2843	You need to filter if the block is invalid as well, there is no need to poll for it.

This revision now requires changes to proceed.Apr 6 2020, 13:43

deadalnix requested review of this revision.Apr 6 2020, 16:17

deadalnix added inline comments.

src/validation.cpp
2843	The AvalancheProcessor ditch invalid blocks already. See https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/src/avalanche.cpp$115-129

Fabien accepted this revision.Apr 7 2020, 07:48

This revision is now accepted and ready to land.Apr 7 2020, 07:48

rebase

This revision was landed with ongoing or failed builds.Apr 8 2020, 13:01

Closed by commit rABC9c7b12e6f128: [avalanche] Poll tip candidate rather than eagerly (authored by deadalnix). · Explain Why

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC9c7b12e6f128: [avalanche] Poll tip candidate rather than eagerly.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10144: Diff 18689.Apr 8 2020, 13:16

deadalnix added a commit: rSTAGING9c7b12e6f128: [avalanche] Poll tip candidate rather than eagerly.May 5 2020, 18:54

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

9 lines

test/

functional/

abc-p2p-avalanche.py

7 lines

Diff 17456

View Options

src/validation.cpp