Page MenuHomePhabricator

Start passing some wallet/rpcwallet RPC argument descriptions to RPCHelpMan
ClosedPublic

Authored by nakihito on Apr 14 2020, 22:50.

Details

Summary

This is the first of two patches resulting from breaking the changes
to rpcwallet.cpp into smaller parts.

Partial backport of Core PR14796

Test Plan
mkdir master
mkdir patched

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

On the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched rpcwallethelp.txt

Verify the changes in rpcwallethelp.txt.

Scripts:


D5722diff:

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rpcwallethelp1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10222
Build 18269: Default Diff Build & Tests
Build 18268: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Apr 14 2020, 22:50

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Apr 15 2020, 15:58