Page MenuHomePhabricator
Differential D5734

Allow ConvertBits() to succeed on unpadded zeros
ClosedPublic
Actions

Authored by Fabien on Apr 15 2020, 10:44.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGc8254da60ec2: Allow ConvertBits() to succeed on unpadded zeros
rABCc8254da60ec2: Allow ConvertBits() to succeed on unpadded zeros
Summary

The behavior of ConvertBits() has been simplified in D572 from it's
original form, and would return false when there is any remaining bit
and padding is disabled.
This diff relaxes this requirement to be in par with the original
behavior (see
https://github.com/bitcoin/bitcoin/pull/11167/files#diff-b5877ad42a7dbee9a99cbf0596977fd9).
The call will now returns true if the remaining bits are all zeros.
This is a prerequisite for backporting PR11630.

The cash address decoding is updated to now check the output of
ConvertBits()

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
convert_bits_padding
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10243
Build 18308: Default Diff Build & Tests
Build 18307: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 15 2020, 10:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 15 2020, 10:44
teamcity edited the summary of this revision. (Show Details)Apr 15 2020, 10:45

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 15 2020, 10:45

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien added a child revision: D5735: Simplify Base32 and Base64 conversions.Apr 15 2020, 10:48
teamcity added a comment.Apr 15 2020, 10:57

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10226: Diff 18818.Apr 15 2020, 10:57
deadalnix requested changes to this revision.Apr 15 2020, 15:41
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/cashaddrenc.cpp
143 ↗(On Diff #18818)

What test cases does check for this?

This revision now requires changes to proceed.Apr 15 2020, 15:41
Fabien updated this revision to Diff 18851.Apr 16 2020, 09:11

Remove redundant checks.

teamcity added a comment.Apr 16 2020, 09:12

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien added inline comments.Apr 16 2020, 09:13
src/cashaddrenc.cpp
143 ↗(On Diff #18818)

There is none really, because after the change this check is redundant with the 2 others above.
I updated the diff to remove the redundant check, making the test coverage more obvious. The cashaddrenc_tests/check_padding test is the most relevant test for this check.

teamcity added a comment.Apr 16 2020, 09:15
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

[09:12:03] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851 (1s)
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Enumerating objects: 15, done.        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Counting objects:   6% (1/15)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Counting objects:  13% (2/15)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Counting objects:  20% (3/15)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Counting objects:  26% (4/15)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Counting objects:  33% (5/15)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Counting objects:  40% (6/15)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Counting objects:  46% (7/15)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Counting objects:  53% (8/15)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Counting objects:  60% (9/15)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Counting objects:  66% (10/15)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Counting objects:  73% (11/15)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Counting objects:  80% (12/15)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Counting objects:  86% (13/15)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Counting objects:  93% (14/15)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Counting objects: 100% (15/15)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Counting objects: 100% (15/15), done.        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Compressing objects:  16% (1/6)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Compressing objects:  33% (2/6)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Compressing objects:  50% (3/6)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Compressing objects:  66% (4/6)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Compressing objects:  83% (5/6)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Compressing objects: 100% (6/6)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Compressing objects: 100% (6/6), done.        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] remote: Total 8 (delta 7), reused 2 (delta 2)        
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851] From ssh://reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851]  * [new tag]             phabricator/diff/18851 -> phabricator/diff/18851
[09:12:04]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18851:refs/tags/phabricator/diff/18851]  * [new tag]             phabricator/base/18851 -> phabricator/base/18851
[09:12:04] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git log -n1 --pretty=format:%H%x20%s 4b9222e239ebba4f08352d104dc3507ab97f7991 --
[09:12:04] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git pack-refs --all
[09:12:04] :		 [VCS Root: Bitcoin ABC Staging] Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)
[09:12:04] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] The .git directory is missing in '/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc'. Running 'git init'...
[09:12:04] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git init
[09:12:04] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config lfs.storage /home/teamcity/buildAgent/system/git/git-48AA3180.git/lfs
[09:12:04] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config core.sparseCheckout true
[09:12:04] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config http.sslCAInfo
[09:12:04] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref
[09:12:04] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/18851
[09:12:04] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git log -n1 --pretty=format:%H%x20%s 4b9222e239ebba4f08352d104dc3507ab97f7991 --
[09:12:04] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git -c credential.helper= checkout -q -f phabricator/diff/18851
[09:12:05] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/18851
[09:12:05] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] Cleaning Bitcoin ABC Staging in /home/teamcity/buildAgent/work/jailed-build/bitcoin-abc the file set ALL_UNTRACKED
[09:12:05] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git clean -f -d -x
[09:12:05] : Build preparation done
[09:12:05]E: Step 1/2: Command Line (3m:01s)
[09:12:05] :	 [Step 1/2] Ant JUnit report watcher
[09:12:05] :		 [Ant JUnit report watcher] Watching paths:
[09:12:05] :		 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[09:12:05] :		 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[09:12:05] :	 [Step 1/2] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script233071788186263131
[09:12:05] :	 [Step 1/2] in directory: /home/teamcity/buildAgent/work/jailed-build
[09:12:05] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[09:12:05] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[09:12:05] :	 [Step 1/2] Building base image for: 4b9222e23...
[09:12:05] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[09:12:05] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[09:12:05] :	 [Step 1/2] Tag name: abc-base-image-4b9222e23
[09:15:06]W:	 [Step 1/2] Process exited with code 1
[09:15:06]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)
Harbormaster failed remote builds in B10243: Diff 18851!Apr 16 2020, 09:15
Fabien updated this revision to Diff 18852.Apr 16 2020, 09:17

Rebase

teamcity added a comment.Apr 16 2020, 09:17

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 16 2020, 09:20
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

[09:17:41] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852 (1s)
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Enumerating objects: 15, done.        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Counting objects:   6% (1/15)        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Counting objects:  13% (2/15)        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Counting objects:  20% (3/15)        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Counting objects:  26% (4/15)        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Counting objects:  33% (5/15)        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Counting objects:  40% (6/15)        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Counting objects:  46% (7/15)        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Counting objects:  53% (8/15)        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Counting objects:  60% (9/15)        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Counting objects:  66% (10/15)        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Counting objects:  73% (11/15)        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Counting objects:  80% (12/15)        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Counting objects:  86% (13/15)        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Counting objects:  93% (14/15)        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Counting objects: 100% (15/15)        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Counting objects: 100% (15/15), done.        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Compressing objects:  16% (1/6)        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Compressing objects:  33% (2/6)        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Compressing objects:  50% (3/6)        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Compressing objects:  66% (4/6)        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Compressing objects:  83% (5/6)        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Compressing objects: 100% (6/6)        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Compressing objects: 100% (6/6), done.        
[09:17:42]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] remote: Total 8 (delta 7), reused 2 (delta 2)        
[09:17:43]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852] From ssh://reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging
[09:17:43]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852]  * [new tag]             phabricator/diff/18852 -> phabricator/diff/18852
[09:17:43]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18852:refs/tags/phabricator/diff/18852]  * [new tag]             phabricator/base/18852 -> phabricator/base/18852
[09:17:43] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git log -n1 --pretty=format:%H%x20%s a98bcdd4ac428e9ae72e601ab25f250028e35144 --
[09:17:43] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git pack-refs --all
[09:17:43] :		 [VCS Root: Bitcoin ABC Staging] Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)
[09:17:43] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] The .git directory is missing in '/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc'. Running 'git init'...
[09:17:43] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git init
[09:17:43] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config lfs.storage /home/teamcity/buildAgent/system/git/git-48AA3180.git/lfs
[09:17:43] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config core.sparseCheckout true
[09:17:43] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config http.sslCAInfo
[09:17:43] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref
[09:17:43] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/18852
[09:17:43] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git log -n1 --pretty=format:%H%x20%s a98bcdd4ac428e9ae72e601ab25f250028e35144 --
[09:17:43] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git -c credential.helper= checkout -q -f phabricator/diff/18852
[09:17:43] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/18852
[09:17:43] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] Cleaning Bitcoin ABC Staging in /home/teamcity/buildAgent/work/jailed-build/bitcoin-abc the file set ALL_UNTRACKED
[09:17:43] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git clean -f -d -x
[09:17:43] : Build preparation done
[09:17:43]E: Step 1/2: Command Line (3m:01s)
[09:17:43] :	 [Step 1/2] Ant JUnit report watcher
[09:17:43] :		 [Ant JUnit report watcher] Watching paths:
[09:17:43] :		 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[09:17:43] :		 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[09:17:43] :	 [Step 1/2] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script4585651397833177533
[09:17:43] :	 [Step 1/2] in directory: /home/teamcity/buildAgent/work/jailed-build
[09:17:43] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[09:17:43] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[09:17:43] :	 [Step 1/2] Building base image for: a98bcdd4a...
[09:17:43] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[09:17:43] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[09:17:43] :	 [Step 1/2] Tag name: abc-base-image-a98bcdd4a
[09:20:44]W:	 [Step 1/2] Process exited with code 1
[09:20:44]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)
Harbormaster failed remote builds in B10244: Diff 18852!Apr 16 2020, 09:20
Fabien updated this revision to Diff 18853.Apr 16 2020, 09:22

Rebase again

teamcity added a comment.Apr 16 2020, 09:23

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 16 2020, 09:26
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853] remote: Compressing objects:  80% (69/86)        
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853] remote: Compressing objects:  81% (70/86)        
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853] remote: Compressing objects:  82% (71/86)        
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853] remote: Compressing objects:  83% (72/86)        
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853] remote: Compressing objects:  84% (73/86)        
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853] remote: Compressing objects:  86% (74/86)        
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853] remote: Compressing objects:  87% (75/86)        
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853] remote: Compressing objects:  88% (76/86)        
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853] remote: Compressing objects:  89% (77/86)        
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853] remote: Compressing objects:  90% (78/86)        
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853] remote: Compressing objects:  91% (79/86)        
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853] remote: Compressing objects:  93% (80/86)        
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853] remote: Compressing objects:  94% (81/86)        
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853] remote: Compressing objects:  95% (82/86)        
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853] remote: Compressing objects:  96% (83/86)        
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853] remote: Compressing objects:  97% (84/86)        
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853] remote: Compressing objects:  98% (85/86)        
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853] remote: Compressing objects: 100% (86/86)        
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853] remote: Compressing objects: 100% (86/86), done.        
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853] remote: Total 88 (delta 79), reused 2 (delta 2)        
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853] From ssh://reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853]  * [new tag]             phabricator/diff/18853 -> phabricator/diff/18853
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853]  * [new tag]             phabricator/base/18841 -> phabricator/base/18841
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853]  * [new tag]             phabricator/base/18842 -> phabricator/base/18842
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853]  * [new tag]             phabricator/base/18843 -> phabricator/base/18843
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853]  * [new tag]             phabricator/base/18844 -> phabricator/base/18844
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853]  * [new tag]             phabricator/base/18846 -> phabricator/base/18846
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853]  * [new tag]             phabricator/base/18850 -> phabricator/base/18850
[09:23:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/18853:refs/tags/phabricator/diff/18853]  * [new tag]             phabricator/base/18853 -> phabricator/base/18853
[09:23:23] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git log -n1 --pretty=format:%H%x20%s d7cf2dd6727a36dacd8daba15d4eac43c2c529fd --
[09:23:23] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git pack-refs --all
[09:23:23] :		 [VCS Root: Bitcoin ABC Staging] Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)
[09:23:23] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] The .git directory is missing in '/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc'. Running 'git init'...
[09:23:23] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git init
[09:23:23] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config lfs.storage /home/teamcity/buildAgent/system/git/git-48AA3180.git/lfs
[09:23:23] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config core.sparseCheckout true
[09:23:23] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config http.sslCAInfo
[09:23:23] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref
[09:23:23] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/18853
[09:23:23] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git log -n1 --pretty=format:%H%x20%s d7cf2dd6727a36dacd8daba15d4eac43c2c529fd --
[09:23:24] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git -c credential.helper= checkout -q -f phabricator/diff/18853
[09:23:24] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/18853
[09:23:24] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] Cleaning Bitcoin ABC Staging in /home/teamcity/buildAgent/work/jailed-build/bitcoin-abc the file set ALL_UNTRACKED
[09:23:24] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git clean -f -d -x
[09:23:24] : Build preparation done
[09:23:24]E: Step 1/2: Command Line (3m:01s)
[09:23:24] :	 [Step 1/2] Ant JUnit report watcher
[09:23:24] :		 [Ant JUnit report watcher] Watching paths:
[09:23:24] :		 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[09:23:24] :		 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[09:23:24] :	 [Step 1/2] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script6424184602806513449
[09:23:24] :	 [Step 1/2] in directory: /home/teamcity/buildAgent/work/jailed-build
[09:23:24] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[09:23:24] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[09:23:24] :	 [Step 1/2] Building base image for: d7cf2dd67...
[09:23:24] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[09:23:24] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[09:23:24] :	 [Step 1/2] Tag name: abc-base-image-d7cf2dd67
[09:26:25]W:	 [Step 1/2] Process exited with code 1
[09:26:25]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)
Harbormaster failed remote builds in B10245: Diff 18853!Apr 16 2020, 09:26
teamcity added a comment.Apr 16 2020, 10:15

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 16 2020, 10:43

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10245: Diff 18853.Apr 16 2020, 10:43
deadalnix accepted this revision.Apr 16 2020, 13:06
This revision is now accepted and ready to land.Apr 16 2020, 13:06
Closed by commit rABCc8254da60ec2: Allow ConvertBits() to succeed on unpadded zeros (authored by Fabien). · Explain WhyApr 16 2020, 13:20
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCc8254da60ec2: Allow ConvertBits() to succeed on unpadded zeros.
Fabien added a commit: rSTAGINGc8254da60ec2: Allow ConvertBits() to succeed on unpadded zeros.May 5 2020, 18:59

Revision Contents
Changeset List

PathSize
src/
18 lines
test/
16 lines
util/
12 lines

Diff 18851

View Options

src/cashaddrenc.cpp

Loading...
View Options

src/test/util_tests.cpp

Loading...
View Options

src/util/strencodings.h

Loading...