Page MenuHomePhabricator
Differential D5735

Simplify Base32 and Base64 conversions
ClosedPublic
Actions

Authored by Fabien on Apr 15 2020, 10:48.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING9fa8a6f08ee9: Simplify Base32 and Base64 conversions
rABC9fa8a6f08ee9: Simplify Base32 and Base64 conversions
Summary
Generalize ConvertBits a bit to also be usable for the existing Base32
and Base64 convertions (rather than just for Bech32).

Backport of core PR11630.

Depends on D5734.

The key_io.cpp changes are not ported because they are segwit related,
however some cashaddrenc.cpp and util_tests.cpp changes were required.

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11630
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10227
Build 18278: Default Diff Build & Tests
Build 18277: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 15 2020, 10:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 15 2020, 10:48
teamcity edited the summary of this revision. (Show Details)Apr 15 2020, 10:48

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 15 2020, 10:48

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 15 2020, 11:01

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10227: Diff 18819.Apr 15 2020, 11:01
Fabien added a child revision: D5736: Add pf_invalid arg to std::string DecodeBase{32,64}.Apr 15 2020, 11:25
deadalnix accepted this revision.Apr 15 2020, 15:51
This revision is now accepted and ready to land.Apr 15 2020, 15:51
Closed by commit rABC9fa8a6f08ee9: Simplify Base32 and Base64 conversions (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by Fabien). · Explain WhyApr 16 2020, 13:25
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC9fa8a6f08ee9: Simplify Base32 and Base64 conversions.
Fabien added a commit: rSTAGING9fa8a6f08ee9: Simplify Base32 and Base64 conversions.May 5 2020, 18:59

Revision Contents
Changeset List

PathSize
src/
6 lines
test/
4 lines
4 lines
12 lines
util/
6 lines
298 lines

Diff 18819

View Options

src/cashaddrenc.cpp

Loading...
View Options

src/test/base32_tests.cpp

Loading...
View Options

src/test/base64_tests.cpp

Loading...
View Options

src/test/util_tests.cpp

Loading...
View Options

src/util/strencodings.h

Loading...
View Options

src/util/strencodings.cpp

Loading...