[backport#15087] Error if rpcpassword contains hash in conf sections
ClosedPublic
Actions

Authored by majcosta on Apr 17 2020, 03:49.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGcd52fd65a466: [backport#15087] Error if rpcpassword contains hash in conf sections
rABCcd52fd65a466: [backport#15087] Error if rpcpassword contains hash in conf sections

Summary

8cff83124bcac936ecc6add6dca72b125a79a08f Error if rpcpassword contains hash in conf sections (MeshCollider)

Pull request description:

Fixes #15075

Tree-SHA512: 08ba2a2e9a7ea228fc0e0ff9aa76da1fecbe079e3b388304a28b6399e338a4b3a38b03ab03aca880e75f14a8d2ba75ceb31a385d7989cd66db5193a79f32c4e5

Depends on D5756

This is a backport of Core PR15087

Test Plan

ninja
test_runner.py feature_config_args.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Apr 17 2020, 03:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 17 2020, 03:49

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10266: Diff 18888.Apr 17 2020, 04:04

majcosta added a child revision: D5758: [backport#15335] Fix lack of warning of unrecognized section names.Apr 17 2020, 05:04

Fabien accepted this revision.Apr 17 2020, 11:36

This revision is now accepted and ready to land.Apr 17 2020, 11:36

Closed by commit rABCcd52fd65a466: [backport#15087] Error if rpcpassword contains hash in conf sections (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhyApr 17 2020, 13:45

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCcd52fd65a466: [backport#15087] Error if rpcpassword contains hash in conf sections.

majcosta added a commit: rSTAGINGcd52fd65a466: [backport#15087] Error if rpcpassword contains hash in conf sections.May 5 2020, 19:00

Revision Contents
Changeset List

Path

Size

src/

util/

system.cpp

3 lines

test/

functional/

feature_config_args.py

11 lines

Diff 18901

View Options

src/util/system.cpp