[backport#15629] init: Throw error when network specific config is ignored
ClosedPublic
Actions

Authored by majcosta on Apr 17 2020, 06:06.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGe3cb37b2d638: [backport#15629] init: Throw error when network specific config is ignored
rABCe3cb37b2d638: [backport#15629] init: Throw error when network specific config is ignored

Summary

fae38c3dc6 doc: Fix all typos reported by codespell (MarcoFalke)
fa9058f0ed doc: Add release notes for 15629 (MarcoFalke)
fa4a922d78 qa: Add test for missing testnet section in conf file (MarcoFalke)
dddd6f0f58 init: Throw error when network specific config is ignored (MarcoFalke)

Pull request description:

This should have no effect on mainnet users, but simplifies testing, where config settings are currently ignored with only a warning. Fix this by making it an error.

Issues:
*  bitcoin client 0.17.0 ignores wallet's name (file) #14523
*  Can't set custom rpcport on testnet #13777
* ...

ACKs for commit fae38c:

Tree-SHA512: 2e209526898eea6e444c803ec2666989cee4ca137492d32984998733c50a70056cb54657df8dc3027a6a0612738a8afce0bc35824b868c5f22281e00e0188530

Depends on D5758

This is a backport of Core PR15629

Test Plan

ninja check
test_runner.py feature_config_args.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Apr 17 2020, 06:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 17 2020, 06:06

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

majcosta edited the summary of this revision. (Show Details)Apr 17 2020, 06:07

majcosta added a parent revision: D5758: [backport#15335] Fix lack of warning of unrecognized section names.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10268: Diff 18890.Apr 17 2020, 06:21

Please add the release-notes entry.

This revision now requires changes to proceed.Apr 17 2020, 11:53

added release-notes.md changes back

Fabien accepted this revision.Apr 17 2020, 14:14

Fabien added inline comments.

doc/release-notes.md
15 ↗	(On Diff #18904)	Missing newline

This revision is now accepted and ready to land.Apr 17 2020, 14:14

added newline to release-notes.md EOF

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10274: Diff 18904.Apr 17 2020, 15:15

This revision was landed with ongoing or failed builds.Apr 17 2020, 15:18

Closed by commit rABCe3cb37b2d638: [backport#15629] init: Throw error when network specific config is ignored (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain Why

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCe3cb37b2d638: [backport#15629] init: Throw error when network specific config is ignored.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10276: Diff 18908.Apr 17 2020, 15:33

majcosta added a commit: rSTAGINGe3cb37b2d638: [backport#15629] init: Throw error when network specific config is ignored.May 5 2020, 19:01

Revision Contents
Changeset List

Path

Size

doc/

release-notes.md

9 lines

src/

init.cpp

32 lines

test/

functional/

feature_config_args.py

5 lines

Diff 18913

View Options

doc/release-notes.md

View Options

src/init.cpp

View Options

test/functional/feature_config_args.py

[backport#15629] init: Throw error when network specific config is ignoredClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 18913

doc/release-notes.md

src/init.cpp

test/functional/feature_config_args.py

[backport#15629] init: Throw error when network specific config is ignored
ClosedPublic
Actions

Revision Contents
Changeset List