Catch exception by ref in wallettool.cpp
ClosedPublic
Actions

Authored by deadalnix on Apr 17 2020, 15:32.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGb93a3dba4200: Catch exception by ref in wallettool.cpp
rABCb93a3dba4200: Catch exception by ref in wallettool.cpp

Summary

Catching exception by value is a bad practice, notably because it can lead to slicing.

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

wallettoolexception

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10277
Build 18376: Default Diff Build & Tests
Build 18375: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 17 2020, 15:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 17 2020, 15:32

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10277: Diff 18914.Apr 17 2020, 16:41

Fabien accepted this revision.Apr 17 2020, 16:50

This revision is now accepted and ready to land.Apr 17 2020, 16:50

Closed by commit rABCb93a3dba4200: Catch exception by ref in wallettool.cpp (authored by deadalnix). · Explain WhyApr 18 2020, 06:55

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCb93a3dba4200: Catch exception by ref in wallettool.cpp.

deadalnix added a commit: rSTAGINGb93a3dba4200: Catch exception by ref in wallettool.cpp.May 5 2020, 19:02

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallettool.cpp

2 lines

Diff 18914

View Options

Catch exception by ref in wallettool.cppClosedPublicActions