Page MenuHomePhabricator
Differential D5767

scripted-diff: Use Flags enum in AddArg()
ClosedPublic
Actions

Authored by deadalnix on Apr 18 2020, 07:10.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGfd105ab49f3c: scripted-diff: Use Flags enum in AddArg()
rABCfd105ab49f3c: scripted-diff: Use Flags enum in AddArg()
Summary

-BEGIN VERIFY SCRIPT-
sed -i 's/const bool debug_only,/unsigned int flags, &/' src/util/system.h src/util/system.cpp
sed -i -E 's/(true|false), OptionsCategory::/ArgsManager::ALLOW_ANY, &/' $(git grep --files-with-matches 'AddArg(' src)
-END VERIFY SCRIPT-

This is a partial backport of Core PR16097 : https://github.com/bitcoin/bitcoin/pull/16097/commits/1b4b9422cad28d1bead24ff5fd472536954cfaf9

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr16097-4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10286
Build 18393: Default Diff Build & Tests
Build 18392: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 18 2020, 07:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 18 2020, 07:10
teamcity edited the summary of this revision. (Show Details)Apr 18 2020, 07:10

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix added a child revision: D5768: scripted-diff: Use ArgsManager::DEBUG_ONLY flag.Apr 18 2020, 07:22
teamcity added a comment.Apr 18 2020, 07:24

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Harbormaster completed remote builds in B10286: Diff 18928.Apr 18 2020, 07:49
teamcity added a comment.Apr 18 2020, 07:49

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Fabien accepted this revision.Apr 20 2020, 08:00
This revision is now accepted and ready to land.Apr 20 2020, 08:00
Closed by commit rABCfd105ab49f3c: scripted-diff: Use Flags enum in AddArg() (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by deadalnix). · Explain WhyApr 20 2020, 13:21
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCfd105ab49f3c: scripted-diff: Use Flags enum in AddArg().
deadalnix added a commit: rSTAGINGfd105ab49f3c: scripted-diff: Use Flags enum in AddArg().May 5 2020, 19:02
PiRK mentioned this in D10305: Use Flags enum in AddArg() (follow-up).Oct 12 2021, 08:30
PiRK mentioned this in rABC67e5b25078d5: Use Flags enum in AddArg() (follow-up).Oct 14 2021, 06:21

Revision Contents
Changeset List

PathSize
src/
bench/
26 lines
45 lines
61 lines
26 lines
6 lines
297 lines
qt/
17 lines
rpc/
test/
3 lines
seeder/
58 lines
test/
3 lines
3 lines
3 lines
util/
3 lines
6 lines
wallet/
45 lines

Diff 18928

View Options

src/bench/bench_bitcoin.cpp

Loading...
View Options

src/bitcoin-cli.cpp

Loading...
View Options

src/bitcoin-tx.cpp

Loading...
View Options

src/bitcoin-wallet.cpp

Loading...
View Options

src/chainparamsbase.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/rpc/test/server_tests.cpp

Loading...
View Options

src/seeder/main.cpp

Loading...
View Options

src/test/getarg_tests.cpp

Loading...
View Options

src/test/main.cpp

Loading...
View Options

src/test/util_tests.cpp

Loading...
View Options

src/util/system.h

Loading...
View Options

src/util/system.cpp

Loading...
View Options

src/wallet/init.cpp

Loading...