Page MenuHomePhabricator
Differential D5875

Pass some rpc/blockchain RPC results and examples to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 28 2020, 21:09.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING4bc2f9217b1e: Pass some rpc/blockchain RPC results and examples to RPCHelpMan
rABC4bc2f9217b1e: Pass some rpc/blockchain RPC results and examples to RPCHelpMan
Summary

Partial backport of Core PR14987

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

Then on the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched blockchain1.diff

Verify changes in blockchain1.diff.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

blockchain1.diff:

blockchain1.diff804 BDownload

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14987-blockchain1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10456
Build 18732: Default Diff Build & Tests
Build 18731: arc lint + arc unit

Event Timeline

nakihito created this revision.Apr 28 2020, 21:09
Owners added a reviewer: Restricted Owners Package.Apr 28 2020, 21:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 28 2020, 21:09
nakihito planned changes to this revision.Apr 28 2020, 21:09
teamcity edited the summary of this revision. (Show Details)Apr 28 2020, 21:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster failed remote builds in B10454: Diff 19210!Apr 28 2020, 21:09
nakihito edited the test plan for this revision. (Show Details)Apr 28 2020, 21:23
nakihito updated this revision to Diff 19213.Apr 28 2020, 21:29

Fixed layout.

teamcity added a comment.Apr 28 2020, 21:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 28 2020, 21:48

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10456: Diff 19213.Apr 28 2020, 21:48
Fabien accepted this revision.Apr 29 2020, 07:11
This revision is now accepted and ready to land.Apr 29 2020, 07:11
Closed by commit rABC4bc2f9217b1e: Pass some rpc/blockchain RPC results and examples to RPCHelpMan (authored by nakihito). · Explain WhyApr 29 2020, 17:43
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC4bc2f9217b1e: Pass some rpc/blockchain RPC results and examples to RPCHelpMan.
nakihito added a commit: rSTAGING4bc2f9217b1e: Pass some rpc/blockchain RPC results and examples to RPCHelpMan.May 5 2020, 19:13

Revision Contents
Changeset List

PathSize
src/
rpc/
725 lines

Diff 19213

View Options

src/rpc/blockchain.cpp

Loading...