Page MenuHomePhabricator

Add util::Settings struct and helper functions.
ClosedPublic

Authored by deadalnix on Apr 29 2020, 14:47.

Details

Summary

Implement merging of settings from different sources (command line and config
file) separately from parsing code in system.cpp, so it is easier to add new
sources.

Document current inconsistent merging behavior without changing it.

This commit only adds new settings code without using it. The next commit calls
the new code to replace existing code in system.cpp.

Co-authored-by: John Newbery <john@johnnewbery.com>

This is a partial backport of Core PR15934 : https://github.com/bitcoin/bitcoin/pull/15934/commits/9dcb952fe5f85529ab28e091af7534e72c21c90f

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15934-3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10473
Build 18766: Default Diff Build & Tests
Build 18765: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Apr 29 2020, 15:22